Unify UI Tests and Enforce Swift 6.3#25
Merged
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 155 files, which is 105 over the limit of 50. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (28)
📒 Files selected for processing (564)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
…fixBuilds # Conflicts: # Package.swift # Sources/SpeziLocation/LocationTasks/LocationTaskManager.swift # Sources/XCTRuntimeAssertions/Deprecations.swift # Sources/XCTRuntimeAssertions/XCTRuntimePrecondition.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
The monorepo's UI-test projects duplicated configuration across packages and had drifted from current Xcode defaults. Moving the package to Swift 6.3 and Xcode 27 also exposed concurrency diagnostics, nondeterministic unit/UI tests, and legacy runtime-assertion test infrastructure that is now superseded by Swift Testing's native exit tests.
No related issue was identified.
⚙️ Release Notes
XCTRuntimeAssertionsproduct and migrate repository consumers to Swift 6.3 native exit tests on macOS. Deprecate allRuntimeAssertionsTestingAPIs on every platform while retaining their compatibility self-tests.XCTRuntimeAssertionsremoval is a breaking change for test targets that import it. Migrate assertion/precondition tests to native Swift Testing exit tests:📚 Documentation
✅ Testing
python3 Scripts/generate-ui-test-projects.py --checkswift package dump-packagewith Swift 6.3The complete unit/UI and deployment-floor matrix is also validated by PR CI.
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: