Adopt the Organization Repository Standards - #117
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds a repository standards workflow and upgrades reusable validation workflows to Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/compliance/tests/test_release_governance.py (1)
330-331: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winCover the new standards workflow in the version assertion.
This test validates only the three references in
.github/workflows/validate.yml. The PR also addsrepository-standards.yml@v0.5in.github/workflows/repository-standards.yml. A future downgrade of that reference could pass this test.Add an assertion for the new workflow.
Proposed test update
validation = Path(".github/workflows/validate.yml").read_text(encoding="utf-8") + standards = Path( + ".github/workflows/repository-standards.yml" + ).read_text(encoding="utf-8") assert validation.count("SchmiedmayerLab/.github/.github/workflows/") == 3 assert validation.count("`@v0.5`") == 3 + assert standards.count( + "SchmiedmayerLab/.github/.github/workflows/" + ) == 1 + assert standards.count("`@v0.5`") == 1🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/compliance/tests/test_release_governance.py` around lines 330 - 331, Update the version assertions in the relevant release-governance test to also verify the `@v0.5` reference in repository-standards.yml, ensuring the new standards workflow is covered alongside the existing three workflow references.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 15: Update the license badge link in README.md to use the
repository-relative LICENSE.md target, matching the existing reference used
elsewhere in the document, instead of the main-branch GitHub URL.
---
Nitpick comments:
In `@packages/compliance/tests/test_release_governance.py`:
- Around line 330-331: Update the version assertions in the relevant
release-governance test to also verify the `@v0.5` reference in
repository-standards.yml, ensuring the new standards workflow is covered
alongside the existing three workflow references.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: dd45b29b-5e99-44df-a6e1-d223613cf72f
📒 Files selected for processing (10)
.github/workflows/repository-standards.yml.github/workflows/validate.yml.linkspector.ymlCITATION.cffCONTRIBUTING.mdCONTRIBUTORS.mdLICENSE.mdREADME.mdSECURITY.mdpackages/compliance/tests/test_release_governance.py
💤 Files with no reviewable changes (2)
- CONTRIBUTING.md
- SECURITY.md
♻️ Current situation & Problem
SchmiedmayerLab/.githubdefines the organization repository standard inREPOSITORY_STANDARDS.mdand enforces it inrepository-standards.yml. This repository does not call that workflow yet.No related issue was identified.
⚙️ Release Notes
repository-standards.yml@v0.5from a new.github/workflows/repository-standards.yml.v0.5.CITATION.cffwith the fields Zenodo reads, and bringCONTRIBUTORS.mdto the documented shape.📚 Documentation
The standard is documented in
REPOSITORY_STANDARDS.md.✅ Testing
actionlint,yamllintandreuse lintrepository-standards.yml@v0.5runs on this pull requestCode of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: