Skip to content

Conversation

@hatrit
Copy link
Member

@hatrit hatrit commented Aug 25, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

added an endemic SECIR-type IDE model, meaning we allow for natural birth and death.
-All in all the structure is similar to the ide_secir model and similar functionalities are implemented. One big difference besides the birth and death rate is that in this case another approach for the initialization is used. We just assume to know the sizes of the compartments at start time 0.

  • Added the folder ide_endemic_secir in the folder models
  • In the foler are the following files:
  • infection_state.h: Definition of infection states and transitions

  • parameters.h: all the given parameters are defined here

  • computed_parameters.h: Contains the class CompParameter, where we compute all the model parameters, we can compute before the start of the iteration.

  • model.h/model.cpp: Functions needed in the iteration. two different schemes are implemented, as there a two ways to implement the compartments, everything computed with the update scheme is names _update

  • normalized_model.h/normalized_model.cpp: Againg Functions needed in the iteration are implemented. But in this case we model a normalized SECIR-type IDE model.

  • Added the example ide_endemic_secir.cpp in the examples folder.

-No tests yet!

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1208

@hatrit hatrit requested a review from annawendler August 25, 2025 11:35
@hatrit hatrit linked an issue Aug 25, 2025 that may be closed by this pull request
Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of computed_parameters.h

Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining review of ide_endemic_secir folder

@mknaranja mknaranja changed the title 1208 implement endemic ide model 1208 implement endemic IDE model Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement endemic IDE model

3 participants