-
Notifications
You must be signed in to change notification settings - Fork 19
1386 implement influenza model #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
========================================
Coverage 97.28% 97.29%
========================================
Files 175 178 +3
Lines 15306 15635 +329
========================================
+ Hits 14891 15212 +321
- Misses 415 423 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! :) Most of my comments are regarding naming of variables/parameters where I made some suggestions.
Co-authored-by: annawendler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several conversations that you resolved without making any changes or commenting. Can you add comments where you disagree so we can discuss?
docs/source/cpp/models/oseirv.rst
Outdated
| - ``SeasonalityAmplitude`` | ||
| - Amplitude of the seasonal modulation :math:`\exp(\delta\,\sin(2\pi(t/52 - t_z + t_s)))`. | ||
| * - :math:`t_z` | ||
| - ``ShiftTZ`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the parameter names need to be updated.
| * | ||
| * We assume that no one is initially infected or exposed at the beginning of the season. | ||
| * Infections are seeded later via the OutsideFoI parameter. | ||
| * The destinction into the 2 layers of susceptibility is done via the parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * The destinction into the 2 layers of susceptibility is done via the parameters. | |
| * The distinction into the 2 layers of susceptibility is done via the parameters. |
| }; | ||
|
|
||
| /** | ||
| * @brief Transition/recovery rate in 1/week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer two separate parameters for the transitions and then setting it equal in the example since it allows more flexibility for the user.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)