Skip to content

Conversation

@annawendler
Copy link
Member

@annawendler annawendler commented Oct 24, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Merge examples ide_secir and ide_secir_ageres to avoid code duplication
  • Add documentation in IDE-SECIR examples, for implemented formulas in general and in get_mean() of StateAgeFunction

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@annawendler annawendler linked an issue Oct 24, 2025 that may be closed by this pull request
2 tasks
@annawendler annawendler self-assigned this Oct 24, 2025
@annawendler annawendler linked an issue Oct 24, 2025 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.28%. Comparing base (52ed3c1) to head (2352ea2).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1402    +/-   ##
========================================
  Coverage   97.27%   97.28%            
========================================
  Files         175      180     +5     
  Lines       15306    15642   +336     
========================================
+ Hits        14889    15217   +328     
- Misses        417      425     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@annawendler annawendler changed the title 1392 update IDE examples and improve some documentation 1392 update IDE-SECIR examples and improve some documentation Oct 27, 2025
@annawendler annawendler requested a review from jubicker October 30, 2025 14:21
@annawendler annawendler requested a review from jubicker November 4, 2025 10:01
@annawendler annawendler merged commit b44ce1d into main Nov 4, 2025
57 checks passed
@annawendler annawendler deleted the 1392-improve-examples-and-code-documentation-of-ide-secir-model branch November 4, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve examples and code documentation of IDE-SECIR model

3 participants