-
-
Notifications
You must be signed in to change notification settings - Fork 52
Add smoothed linear interpolation #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
A question related to SparseConnectivityTracer: The DataInterpolations extension there handles each interpolation type individually, so new interpolation types do not work out of the box with SparseConnectivityTracer. Specifically, |
The alternative would be to move the extension from SCT to this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a small comment. Otherwise LGTM!
docs/src/methods.md
Outdated
@@ -18,13 +18,24 @@ to show the fitting curve. | |||
|
|||
## Linear Interpolation | |||
|
|||
This is a linear interpolation between the ends points of the interval of input data points. | |||
This is a continuously differentiable linear interpolation with an interval around each data point replaced by spline section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done by mistake? It should be for SmoothedLinearInterpolation?
I am fine moving the extension here if that helps. |
That's probably the right way to do it. It's easier to maintain it here. |
How should we handle this? I haven't "swapped" extensions before, so I'm not sure what to watch out for. |
Let's use that. The old one supports up to v0.6 final, delete from the v0.7, and then have this one only start with v0.7 support. That makes it pretty clean |
Tagged SCT |
Continuing that thread here: #444 |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
I first described this method here. I'm not sure whether I should put all of that in the DataInterpolations docs.