Skip to content

Add smoothed linear interpolation #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SouthEndMusic
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

I first described this method here. I'm not sure whether I should put all of that in the DataInterpolations docs.

@SouthEndMusic
Copy link
Member Author

image

@SouthEndMusic
Copy link
Member Author

A question related to SparseConnectivityTracer: The DataInterpolations extension there handles each interpolation type individually, so new interpolation types do not work out of the box with SparseConnectivityTracer. Specifically, SparseConnectivityTracer needs to know whether the first and second derivative of an interpolation type are identically zero. Would it be ok with you @sathvikbhagavan @ChrisRackauckas if this information lives in DataInterpolations instead of in the SparseConnectivityTracer extension for DataInterpolations?

@adrhill
Copy link

adrhill commented Jul 10, 2025

The alternative would be to move the extension from SCT to this repo.

Copy link
Member

@sathvikbhagavan sathvikbhagavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a small comment. Otherwise LGTM!

@@ -18,13 +18,24 @@ to show the fitting curve.

## Linear Interpolation

This is a linear interpolation between the ends points of the interval of input data points.
This is a continuously differentiable linear interpolation with an interval around each data point replaced by spline section.
Copy link
Member

@sathvikbhagavan sathvikbhagavan Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done by mistake? It should be for SmoothedLinearInterpolation?

@sathvikbhagavan
Copy link
Member

The alternative would be to move the extension from SCT to this repo.

I am fine moving the extension here if that helps.

@ChrisRackauckas
Copy link
Member

That's probably the right way to do it. It's easier to maintain it here.

@adrhill
Copy link

adrhill commented Jul 11, 2025

How should we handle this? I haven't "swapped" extensions before, so I'm not sure what to watch out for.
SCT has an upcoming v0.7.0 release (refactoring the internal type system, but we'll conservatively tag it as breaking), maybe that helps.

@ChrisRackauckas
Copy link
Member

Let's use that. The old one supports up to v0.6 final, delete from the v0.7, and then have this one only start with v0.7 support. That makes it pretty clean

@adrhill
Copy link

adrhill commented Jul 14, 2025

Tagged SCT v1.0.0 without the extension.

@ChrisRackauckas
Copy link
Member

Continuing that thread here: #444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants