Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MKL #428

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Remove MKL #428

merged 1 commit into from
Nov 10, 2023

Conversation

ChrisRackauckas
Copy link
Member

See the discussion in #427

See the discussion in #427
@chriselrod
Copy link
Contributor

Why weren't we just ccalling the functions we want from MLK_jll?

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #428 (fa85bb8) into main (f5a2c07) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   63.80%   64.17%   +0.36%     
==========================================
  Files          26       26              
  Lines        2097     2085      -12     
==========================================
  Hits         1338     1338              
+ Misses        759      747      -12     
Files Coverage Δ
src/LinearSolve.jl 89.04% <ø> (ø)

... and 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ChrisRackauckas
Copy link
Member Author

See the discussion in #427. You can't do that with SuiteSparse.

@ChrisRackauckas ChrisRackauckas merged commit 2e67a2f into main Nov 10, 2023
@ChrisRackauckas ChrisRackauckas deleted the mkl branch November 10, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants