Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite MOE algo #394

Merged
merged 16 commits into from
Sep 9, 2022

Conversation

vikram-s-narayan
Copy link
Contributor

@vikram-s-narayan vikram-s-narayan commented Aug 19, 2022

As mentioned in issue #387, MOE had an issue with accuracy when compared to accuracy of constituent surrogate experts.

This rewrite of the algo significantly improves accuracy. For the example, given in that issue thread earlier here are the results:

Old
MOE RMSE: 3.09
Kriging RMSE: 0.10
RBF RMSE: 0.64

Now
MOE RMSE: ~ 0.0069

To do:

  1. Register package (I will do this after this PR is merged)
  2. Add documentation (I will do this after registering package as users will need to be able to use MOE)

@vikram-s-narayan
Copy link
Contributor Author

SurrogatesMOE Tests are passing.

@vikram-s-narayan vikram-s-narayan marked this pull request as ready for review August 30, 2022 13:00
@ranjanan
Copy link
Contributor

okay, I'm checking if these tests fail on master too. In which case we can open a new issue about that and fix. #396

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #394 (9c9ef77) into master (8f8128d) will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   79.40%   79.66%   +0.25%     
==========================================
  Files          16       16              
  Lines        2331     2567     +236     
==========================================
+ Hits         1851     2045     +194     
- Misses        480      522      +42     
Impacted Files Coverage Δ
src/Earth.jl 79.37% <0.00%> (-8.56%) ⬇️
src/Lobachevsky.jl 93.38% <0.00%> (-3.86%) ⬇️
src/Surrogates.jl 18.18% <0.00%> (-3.56%) ⬇️
src/Radials.jl 82.75% <0.00%> (-3.10%) ⬇️
src/LinearSurrogate.jl 97.61% <0.00%> (-2.39%) ⬇️
src/SecondOrderPolynomialSurrogate.jl 98.14% <0.00%> (-1.86%) ⬇️
src/GEK.jl 92.94% <0.00%> (-0.73%) ⬇️
src/GEKPLS.jl 94.50% <0.00%> (-0.54%) ⬇️
src/Wendland.jl 100.00% <0.00%> (ø)
src/PolynomialChaos.jl 0.00% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vikram-s-narayan
Copy link
Contributor Author

Have fixed Zygote version in [compat] section of Project.toml to Zygote = "= 0.6.40" as a test in SurrogatesPolyChaos errors with higher Zygote versions (higher than 0.6.43). Have raised an issue with Zygote for this.

@ChrisRackauckas
Copy link
Member

Test failure?

This version restriction is pretty nasty and will cause some downstream issues to be aware of (@DhairyaLGandhi), so it would be good if Dhariya could investigate a fix or if we could push the Zygote folks to help figure out what's going on here.

@ChrisRackauckas ChrisRackauckas merged commit 4dc62e7 into SciML:master Sep 9, 2022
@vikram-s-narayan vikram-s-narayan deleted the surrogates_MOE_updated branch December 5, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants