-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better benchmarking Python version handling #6329
Open
trexfeathers
wants to merge
8
commits into
SciTools:main
Choose a base branch
from
trexfeathers:better_bm_py_ver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6329 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 88 90 +2
Lines 23430 23447 +17
Branches 4361 4361
=======================================
+ Hits 21059 21076 +17
Misses 1644 1644
Partials 727 727 ☔ View full report in Codecov by Sentry. |
We can in theory successfully run benchmarks all the way back to mid 2021 with this change - Iris 3.1! |
⏱️ Performance Benchmark Report: 54cd2b5Performance shifts
Full benchmark results
Generated by GHA run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
Type: Performance
Type: Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Switch from awkward config to a fully customisable script. Should allow new pull requests to introduce different Python versions without any problems (see #6195).
I welcome comments about any extra error handling this might benefit from.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: