Generalise support for netcdf load+save of "special" attributes #6566
+1,100
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6566 +/- ##
==========================================
- Coverage 89.94% 89.93% -0.02%
==========================================
Files 90 91 +1
Lines 24302 24394 +92
Branches 4546 4554 +8
==========================================
+ Hits 21859 21939 +80
- Misses 1674 1686 +12
Partials 769 769 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pp-mo
added
the
benchmark_this
⏱️ Performance Benchmark Report: 71c7bc4Performance shiftsFull benchmark resultsGenerated by GHA run |
pp-mo
force-pushed
the
nc_attribute_handlers
branch
from
ad34c83 to
dc0c441
Compare
…d/save code, not handlers.
…hout split-attrs.
pp-mo
force-pushed
the
nc_attribute_handlers
branch
from
afa11e5 to
9d90853
Compare
Review Notes : changes to considerThe code changes here provoked review of some older behaviour decisions. Here's a summary, which may not be entirely complete: overall
STASH
ukmo__process_flags
GRIB_PARAM
|
Uncertainty remaining
|
pp-mo
force-pushed
the
nc_attribute_handlers
branch
from
78d96e8 to
7226b36
Compare
Update:
I'm now thinking that, without any further changes here, I can just import the tests which are here skipped due to iris-grib not being installed, and run them in the iris-grib repo instead. Does that sound like a good plan ? |
bjlittle
requested changes
Jul 22, 2025
There was a problem hiding this comment.
@pp-mo Looks good.
You've had to grapple with some serious sketchy historical code that's evolved over time. Unifying it should make it more understandable and maintainable.
I can't see any obvious behaviour changes that will upset users, so I'm happy to roll with what you've suggested and we can see whether there are any user edge cases that may require a patch or rebuffing.
Thanks for adding the additional test coverage 🤩💯
Only a few minors to service 👍
github-project-automation
bot
moved this from 🚀 In Progress
to 👀 In Review
in 🦋 Iris 3.13.0
1 task
pp-mo
force-pushed
the
nc_attribute_handlers
branch
from
1c43257 to
1080a1b
Compare
|
Thanks @bjlittle |
bjlittle
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SciTools/iris-grib#596 and SciTools/iris-grib#674
Ties together the handling of STASH, GRIB_PARAM and "ukmo__process_flags" attributes,
which all require special handling on netcdf load+save.
By design, should preserve existing behaviour.
But I have tried to generalise the handling,
( and also rationalise behaviour a wee bit, at least for "ukmo__process_flags" -- though that one is quite obscure ).
TODO:
@staticmethod+ useselfmore(but first, just let's see if it breaks anything I haven't already tried)