Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thorium: Update to version 121.0.6167.204, fix autoupdate & checkver #12758

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

Icey-Glitch
Copy link
Contributor

@Icey-Glitch Icey-Glitch commented Feb 6, 2024

Updates the manifest to support the new versioning in the thorium repo. Now looks for SSE3 version in the release to maintain support for older cpus as before, also adds architecture properties.

@Icey-Glitch
Copy link
Contributor Author

/verify

Copy link
Contributor

github-actions bot commented Feb 6, 2024

All changes look good.

Wait for review from human collaborators.

thorium

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Icey-Glitch
Copy link
Contributor Author

what is the status on this?

@aliesbelik
Copy link
Collaborator

Fixes #12832.

@aliesbelik
Copy link
Collaborator

I'm not sure if we should switch from AVX version (with which manifest was originally merged for version M117.0.5938.157) to SSE3.

On the other hand, IMO, the "default" manifest should operate either the most capable version (which is AVX2) or the most compatible one (which is SSE3), the other modifications could be hosted in Versions bucket.
But there is already PR for AVX2 in Versions: ScoopInstaller/Versions#1438.

So I'm a bit stuck how to handle this situation properly.
@HUMORCE, @niheaven, @rashil2000, could you please advise?

The same refers to Mercury browser (#12132, #12811) from the same author that has 4 release modifications (SSE3/SSE4/AVX/AVX2).

@Icey-Glitch
Copy link
Contributor Author

I think the most reasonable way is to have the most compatible version be in extras.
Versions should have everything else; If AVX2 was the used here i feel like the naming would have to signify that so it would kinda defeat the purpose of it being in extras.

@aliesbelik
Copy link
Collaborator

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

thorium

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik changed the title [email protected]: Fix AutoUpdate & CheckVer thorium: Update to version 121.0.6167.204, fix autoupdate & checkver Feb 27, 2024
@aliesbelik
Copy link
Collaborator

Ok, since no other reactions, switched to SSE3 option and updated to the latest version (121.0.6167.204).
For AVX2 please track ScoopInstaller/Versions#1438 in Versions.

@aliesbelik aliesbelik merged commit 1a25f1c into ScoopInstaller:master Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants