Skip to content

fix: add defaults for units and description when not listed#254

Open
tsurbs wants to merge 1 commit intomainfrom
units-and-description-defaults
Open

fix: add defaults for units and description when not listed#254
tsurbs wants to merge 1 commit intomainfrom
units-and-description-defaults

Conversation

@tsurbs
Copy link
Copy Markdown
Contributor

@tsurbs tsurbs commented May 28, 2025

As in title -- when description is empty, replace it with "No description available." When units are empty, replace w/ "Unknown" units.

(closes #205)

@tsurbs tsurbs requested review from ap-1 and xavilien May 28, 2025 19:55
@tsurbs tsurbs self-assigned this May 28, 2025
@railway-app
Copy link
Copy Markdown

railway-app Bot commented May 28, 2025

This PR was not deployed automatically as @tsurbs does not have access to the Railway project.

In order to get automatic PR deploys, please add @tsurbs to your team on Railway.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmucourses-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 7:55pm

@tsurbs tsurbs changed the title fix: add defaults for units and description when not listed (closes #205) fix: add defaults for units and description when not listed May 28, 2025
@ap-1
Copy link
Copy Markdown
Contributor

ap-1 commented May 28, 2025

#205 has a sub-issue of #20, could that be addressed in this PR as well? (are there any courses missing FCE data we could use to test this?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] No default text for missing fields in CourseCard

2 participants