Skip to content

Add ability to filter by specific summer sessions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsurbs wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add ability to filter by specific summer sessions #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed69018
fix: add defaults for units and description when not listed
tsurbs May 28, 2025
7f88960
feat: add ability to filter by specific summer session
tsurbs May 28, 2025
1dcb010
fix: summer one should match summer all courses
tsurbs May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/backend/src/controllers/courses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,21 @@ export const getFilteredCourses: RequestHandler<
const sessions = singleToArray(req.query.session).flatMap((serializedSession) => {
try {
const session = JSON.parse(serializedSession);
return [{ year: parseInt(session.year), semester: session.semester }];
if (session.session === "summer one" || session.session === "summer two") {
// include summer all results when checking for summer one or two
return [
{ year: parseInt(session.year), semester: "summer", session: session.session },
{ year: parseInt(session.year), semester: "summer", session: "summer all" },
];
}
// otherwise, just return the session as is (could be quatar summer)
return [{ year: parseInt(session.year), semester: session.semester, session: session.session }];
} catch {
// SyntaxError
return [];
}
});

pipeline.push({
$match: {
schedules: {
Expand Down
3 changes: 1 addition & 2 deletions apps/frontend/src/app/api/course.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,9 @@ const fetchCourseInfosByPage = async (
params.append("unitsMin", filters.units.min.toString());
params.append("unitsMax", filters.units.max.toString());
}

if (filters.semesters.active) {
filters.semesters.sessions.forEach((s: Session) =>
params.append("session", JSON.stringify(s))
params.append("session", JSON.stringify(s))
);
}

Expand Down
4 changes: 2 additions & 2 deletions apps/frontend/src/components/CourseCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const CourseCard = ({
<div className="flex flex-row justify-between">
<div>
<div className="text-lg text-gray-700">
{displayUnits(info.units)} units
{displayUnits(info.units) || "Unknown"} units
</div>
</div>
<div>
Expand Down Expand Up @@ -117,7 +117,7 @@ const CourseCard = ({
</div>
{showCourseInfo && (
<div className="col-span-full row-span-1 row-start-3 text-sm leading-relaxed text-gray-600 md:col-span-6 md:row-start-2">
{injectLinks(info.desc)}
{injectLinks(info.desc || "No description available.")}
</div>
)}
</div>
Expand Down
4 changes: 3 additions & 1 deletion apps/frontend/src/components/filters/SemestersOfferedFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import { classNames, sessionToShortString, sessionToString } from "~/app/utils";

const SESSIONS: Session[] = [
{ year: "2025", semester: "fall" },
{ year: "2025", semester: "summer" },
{ year: "2025", semester: "summer", session: "summer one" },
{ year: "2025", semester: "summer", session: "summer two" },
{ year: "2025", semester: "summer", session: "qatar summer" },
{ year: "2025", semester: "spring" },
{ year: "2024", semester: "fall" },
{ year: "2024", semester: "summer" },
Expand Down
Loading