Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+74
to
+79
| start_datetime = datetime.datetime( | ||
| date_obj.year, date_obj.month, date_obj.day, start_time.tm_hour, start_time.tm_min) | ||
| end_datetime = datetime.datetime( | ||
| date_obj.year, date_obj.month, date_obj.day, end_time.tm_hour, end_time.tm_min) | ||
|
|
||
| return [start_datetime.timestamp(), end_datetime.timestamp()] |
There was a problem hiding this comment.
Bug: The script uses timezone-naive datetime objects, causing timestamp() to use the system's local timezone instead of the intended EST. This can generate incorrect timestamps.
Severity: HIGH
Suggested Fix
Use timezone-aware datetime objects. Before calling .timestamp(), attach the correct timezone information (e.g., using zoneinfo or pytz to specify 'America/New_York') to the datetime objects to ensure the generated timestamps are always correct, regardless of the environment.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: apps/frontend/src/components/finals/scripts/generate-final.py#L74-L79
Potential issue: The `generate-final.py` script creates naive `datetime` objects without
timezone information. When `datetime.timestamp()` is called, it implicitly uses the
system's local timezone to generate a Unix timestamp. The code's docstring specifies
that the input times are in EST, but this is not enforced. If the script is run on a
machine not configured to the EST timezone (e.g., a UTC-based server), the timestamps in
the generated `finals.json` will be incorrect, causing final exam times to be displayed
with a significant offset.
Contributor
|
LGTM |
tsurbs
approved these changes
Mar 9, 2026
Contributor
Author
|
Wait I updated the data so there's no weird Cc thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.