Skip to content

kill fces#285

Merged
yl25946 merged 2 commits intomainfrom
kill-fces
Mar 15, 2026
Merged

kill fces#285
yl25946 merged 2 commits intomainfrom
kill-fces

Conversation

@yl25946
Copy link
Copy Markdown
Contributor

@yl25946 yl25946 commented Mar 15, 2026

  • chore: delay
  • emergency kill fces

@railway-app
Copy link
Copy Markdown

railway-app Bot commented Mar 15, 2026

This PR was not deployed automatically as @yl25946 does not have access to the Railway project.

In order to get automatic PR deploys, please add @yl25946 to your workspace on Railway.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmucourses Ready Ready Preview Mar 15, 2026 8:40am
cmucourses-staging Error Error Mar 15, 2026 8:40am

Request Review

@yl25946 yl25946 merged commit 02a951e into main Mar 15, 2026
2 of 4 checks passed
@yl25946 yl25946 deleted the kill-fces branch March 15, 2026 08:41
Comment on lines 75 to +76
showFCEs: (state, action: PayloadAction<boolean>) => {
state.showFCEs = action.payload;
state.showFCEs = false;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The FCE kill switch is incomplete. FCEs can still be enabled on the /saved and /schedules pages via the ShowFilter component, bypassing the intended restriction.
Severity: HIGH

Suggested Fix

To ensure the kill switch is comprehensive, the savedShowFCEs reducer in user.ts should also be hardcoded to return false. This will prevent the ShowFilter component from enabling FCEs on the /saved and /schedules pages.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: apps/frontend/src/app/user.ts#L75-L76

Potential issue: The emergency kill switch for FCEs is incomplete. The pull request
hardcodes the `showFCEs` state to `false`, which disables the feature on the main course
search page. However, a separate state, `savedShowFCEs`, is used for the `/saved` and
`/schedules` pages. This state and its corresponding reducer were not modified.
Consequently, a signed-in user can navigate to their saved courses or schedules, use the
`ShowFilter` component to toggle FCEs on, and successfully view FCE data, bypassing the
intended kill switch.

Did we get this right? 👍 / 👎 to inform future reviews.

yl25946 added a commit that referenced this pull request Mar 15, 2026
This reverts commit 02a951e.
@yl25946 yl25946 mentioned this pull request Mar 15, 2026
yl25946 added a commit that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant