Conversation
Contributor
yl25946
commented
Mar 15, 2026
- chore: delay
- emergency kill fces
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Comment on lines
75
to
+76
| showFCEs: (state, action: PayloadAction<boolean>) => { | ||
| state.showFCEs = action.payload; | ||
| state.showFCEs = false; |
There was a problem hiding this comment.
Bug: The FCE kill switch is incomplete. FCEs can still be enabled on the /saved and /schedules pages via the ShowFilter component, bypassing the intended restriction.
Severity: HIGH
Suggested Fix
To ensure the kill switch is comprehensive, the savedShowFCEs reducer in user.ts should also be hardcoded to return false. This will prevent the ShowFilter component from enabling FCEs on the /saved and /schedules pages.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: apps/frontend/src/app/user.ts#L75-L76
Potential issue: The emergency kill switch for FCEs is incomplete. The pull request
hardcodes the `showFCEs` state to `false`, which disables the feature on the main course
search page. However, a separate state, `savedShowFCEs`, is used for the `/saved` and
`/schedules` pages. This state and its corresponding reducer were not modified.
Consequently, a signed-in user can navigate to their saved courses or schedules, use the
`ShowFilter` component to toggle FCEs on, and successfully view FCE data, bypassing the
intended kill switch.
Did we get this right? 👍 / 👎 to inform future reviews.
Merged
yl25946
added a commit
that referenced
this pull request
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.