fix: different drawers for different devices#824
Open
cnk2024 wants to merge 4 commits into
Open
Conversation
Contributor
cnk2024
commented
Apr 18, 2026
cnk2024
commented
- mobile: bottom sheet or side panel
- desktop: full width or side panel
- mobile: bottom sheet or side panel - desktop: full width or side panel
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Bro why the format check keeps failing 😭 |
Contributor
|
It runs with no error locally |
Arom1a
requested changes
Apr 19, 2026
| @@ -3,19 +3,20 @@ | |||
| const isMobileContext = createContext<boolean | undefined>(undefined); | |||
Contributor
There was a problem hiding this comment.
oops, I think this should be PascalCase
|
|
||
| export const useIsMobileContext = () => { | ||
| const context = useContext(isMobileContext); | ||
| if (context === undefined) throw new Error('Cannot use drawer tabs context outside of provider!'); |
Contributor
There was a problem hiding this comment.
also didn't catch this on previous reviews oops
| window.addEventListener('resize', handleResize); | ||
| return () => window.removeEventListener('resize', handleResize); | ||
| }, []); | ||
| }, [isTouchScreen]); |
Contributor
There was a problem hiding this comment.
did you leave this here for development purpose? I think in real use cases this don't need to be recalculated every render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.