Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10.8 #38

Merged
merged 24 commits into from
Dec 1, 2024
Merged

1.10.8 #38

merged 24 commits into from
Dec 1, 2024

Conversation

Scyye
Copy link
Collaborator

@Scyye Scyye commented Dec 1, 2024

Summary by CodeRabbit

  • New Features

    • Updated CONTRIBUTING.md to clarify plugin rules regarding interactions with Discord bots.
    • Introduced new themes and updated existing ones in the theme management system.
    • Added context menu options for viewing raw data in Group DMs.
    • Enhanced the ShowHiddenChannels plugin to display hidden channels similarly to visible ones.
  • Bug Fixes

    • Improved error handling in various plugins, including badge management and permissions viewing.
    • Fixed padding issues for Discord badge containers.
  • Documentation

    • Updated CONTRIBUTING.md with new plugin rules.
  • Style

    • Enhanced CSS styling for user permissions and roles components.
  • Chores

    • Incremented version number in package.json from 1.10.7 to 1.10.8.

Nuckyz and others added 24 commits November 14, 2024 14:51
Plugins interacting with specific Discord bots are not allowed.
@Scyye Scyye merged commit 157545e into ScyyeCord:main Dec 1, 2024
Copy link

coderabbitai bot commented Dec 1, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces various changes across multiple files, including updates to documentation, version increments, and significant modifications to components and plugins. A new rule regarding plugin interactions with Discord bots has been added to CONTRIBUTING.md. The package.json version has been incremented. Several components have been refactored or removed, particularly related to UI elements and permissions handling. Enhancements include improved error handling, the addition of new features in plugins, and updates to styling. The changes reflect a comprehensive update to the codebase, focusing on functionality and user experience.

Changes

File Path Change Summary
CONTRIBUTING.md Added rule: "No plugins that interact with specific Discord bots (official Discord apps like Youtube WatchTogether are okay)" in "Plugin Rules".
package.json Version updated: "version": "1.10.7""version": "1.10.8".
src/api/ChatButtons.tsx Added property: onAuxClick to ChatBarButtonProps. Updated buttonProps to exclude onAuxClick.
src/components/ExpandableHeader.css Removed CSS classes: .vc-expandableheader-center-flex, .vc-expandableheader-btn.
src/components/ExpandableHeader.tsx Removed component: ExpandableHeader.
src/components/Icons.tsx Updated GithubIcon and WebsiteIcon to render SVG paths directly, removing theme-based image logic.
src/components/PluginSettings/LinkIconButton.tsx Updated GithubLinkIcon and WebsiteLinkIcon to use theme-based fill colors.
src/components/index.ts Removed export of ExpandableHeader.
src/debug/loadLazyChunks.ts Changed foundCssDebuggingLoad from const to let for mutability.
src/plugins/_api/badges/fixDiscordBadgePadding.css Added new CSS rule for padding adjustments on Discord badge containers.
src/plugins/_api/badges/index.tsx Added CSS import for fixDiscordBadgePadding.css. Updated loadBadges function and added getDonorBadges.
src/plugins/betterFolders/index.tsx Enhanced folder management logic, added isBetterFolders variable.
src/plugins/clientTheme/index.tsx Updated authors list, no significant logic changes.
src/plugins/consoleJanitor/index.ts Modified logging behavior and error suppression for deprecated console warnings.
src/plugins/decor/ui/modals/ChangeDecorationModal.tsx Introduced Queue utility for author fetching.
src/plugins/decor/ui/modals/CreateDecorationModal.tsx Updated help message rendering and error handling logic.
src/plugins/emoteCloner/index.tsx Enhanced isGifUrl function for GIF detection.
src/plugins/imageZoom/components/Magnifier.tsx Replaced useLayoutEffect with direct import from @webpack/common.
src/plugins/openInApp/index.ts Updated link handling logic and account view handling.
src/plugins/permissionsViewer/components/RolesAndUsersPermissions.tsx Enhanced permissions handling and internationalization support.
src/plugins/permissionsViewer/components/UserPermissions.tsx Updated permissions handling logic and component structure.
src/plugins/permissionsViewer/index.tsx Removed defaultPermissionsDropdownState setting, updated popout rendering logic.
src/plugins/permissionsViewer/styles.css Added new CSS classes for user permissions layout.
src/plugins/permissionsViewer/utils.ts Removed several permission-related functions and updated to use getGuildPermissionSpecMap.
src/plugins/pictureInPicture/index.tsx Updated regex pattern in plugin patches for improved matching.
src/plugins/roleColorEverywhere/index.tsx Added pollResults setting, refactored color retrieval logic.
src/plugins/shikiCodeblocks.desktop/api/themes.ts Updated theme repository references and added new themes.
src/plugins/showHiddenChannels/index.tsx Removed permission checks for hidden channels, enhanced rendering logic.
src/plugins/showHiddenThings/index.ts Added patch for moderator view on self and updated guild discovery query handling.
src/plugins/silentTyping/index.tsx Replaced SVG icon for toggle button, no logic changes.
src/plugins/viewRaw/index.tsx Added context menu option for viewing raw data in Group DMs.
src/plugins/webContextMenus.web/index.ts Enhanced context menu functionality for images and links.
src/utils/constants.ts Updated developer entries in the Devs constant.
src/webpack/common/react.ts Added export for useLayoutEffect from React.
src/webpack/common/utils.ts Updated mapping logic for zustandCreate, added ToastOptions interface.

Poem

In the code where rabbits play,
New rules and colors come to stay.
With buttons that bounce and badges that shine,
The plugins dance in harmony, oh so fine!
So hop along, dear friends, don't delay,
For every change brings joy our way! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/api/ChatButtons.tsx

Oops! Something went wrong! :(

ESLint: 9.8.0

Error: Key "rules": Key "no-useless-escape":
Value [{"extra":"i"}] should NOT have more than 0 items.

at RuleValidator.validate (/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/config/rule-validator.js:170:27)
at [finalizeConfig] (/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/config/flat-config-array.js:378:23)
at FlatConfigArray.getConfigWithStatus (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/config-array/dist/cjs/index.cjs:1102:55)
at FlatConfigArray.getConfig (/node_modules/.pnpm/@[email protected]/node_modules/@eslint/config-array/dist/cjs/index.cjs:1120:15)
at /node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint.js:884:40
at Array.map (<anonymous>)
at ESLint.lintFiles (/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint.js:882:23)
at async Object.execute (/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli.js:501:23)
at async main (/node_modules/.pnpm/[email protected]/node_modules/eslint/bin/eslint.js:153:22)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1c130d5 and fcece61.

📒 Files selected for processing (35)
  • CONTRIBUTING.md (1 hunks)
  • package.json (1 hunks)
  • src/api/ChatButtons.tsx (2 hunks)
  • src/components/ExpandableHeader.css (0 hunks)
  • src/components/ExpandableHeader.tsx (0 hunks)
  • src/components/Icons.tsx (4 hunks)
  • src/components/PluginSettings/LinkIconButton.tsx (1 hunks)
  • src/components/index.ts (0 hunks)
  • src/debug/loadLazyChunks.ts (1 hunks)
  • src/plugins/_api/badges/fixDiscordBadgePadding.css (1 hunks)
  • src/plugins/_api/badges/index.tsx (1 hunks)
  • src/plugins/betterFolders/index.tsx (2 hunks)
  • src/plugins/clientTheme/index.tsx (1 hunks)
  • src/plugins/consoleJanitor/index.ts (0 hunks)
  • src/plugins/decor/ui/modals/ChangeDecorationModal.tsx (2 hunks)
  • src/plugins/decor/ui/modals/CreateDecorationModal.tsx (3 hunks)
  • src/plugins/emoteCloner/index.tsx (1 hunks)
  • src/plugins/imageZoom/components/Magnifier.tsx (3 hunks)
  • src/plugins/openInApp/index.ts (1 hunks)
  • src/plugins/permissionsViewer/components/RolesAndUsersPermissions.tsx (5 hunks)
  • src/plugins/permissionsViewer/components/UserPermissions.tsx (6 hunks)
  • src/plugins/permissionsViewer/index.tsx (1 hunks)
  • src/plugins/permissionsViewer/styles.css (1 hunks)
  • src/plugins/permissionsViewer/utils.ts (1 hunks)
  • src/plugins/pictureInPicture/index.tsx (1 hunks)
  • src/plugins/roleColorEverywhere/index.tsx (4 hunks)
  • src/plugins/shikiCodeblocks.desktop/api/themes.ts (3 hunks)
  • src/plugins/showHiddenChannels/index.tsx (1 hunks)
  • src/plugins/showHiddenThings/index.ts (2 hunks)
  • src/plugins/silentTyping/index.tsx (1 hunks)
  • src/plugins/viewRaw/index.tsx (1 hunks)
  • src/plugins/webContextMenus.web/index.ts (1 hunks)
  • src/utils/constants.ts (2 hunks)
  • src/webpack/common/react.ts (2 hunks)
  • src/webpack/common/utils.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.