Skip to content

Postgres: combine SET TRANSACTION ISOLATION LEVEL & ACCESS MODE into a single statement #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Expurple merged 3 commits into from
Jan 6, 2026
Merged

Postgres: combine SET TRANSACTION ISOLATION LEVEL & ACCESS MODE into a single statement #2893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90cbe0c
Postgres: combine SET TRANSACTION ISOLATION LEVEL & ACCESS MODE into …
WaterWhisperer Jan 3, 2026
e24c02c
clippy
WaterWhisperer Jan 5, 2026
97db0ae
Remove unnecessary `,`
WaterWhisperer Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions sea-orm-sync/src/driver/sqlx_postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,23 +317,21 @@ pub(crate) fn set_transaction_config(
isolation_level: Option<IsolationLevel>,
access_mode: Option<AccessMode>,
) -> Result<(), DbErr> {
let mut settings = Vec::new();

if let Some(isolation_level) = isolation_level {
let stmt = Statement {
sql: format!("SET TRANSACTION ISOLATION LEVEL {isolation_level}"),
values: None,
db_backend: DbBackend::Postgres,
};
let query = sqlx_query(&stmt);
conn.execute(query).map_err(sqlx_error_to_exec_err)?;
settings.push(format!("ISOLATION LEVEL {isolation_level}"));
}

if let Some(access_mode) = access_mode {
let stmt = Statement {
sql: format!("SET TRANSACTION {access_mode}"),
values: None,
db_backend: DbBackend::Postgres,
};
let query = sqlx_query(&stmt);
conn.execute(query).map_err(sqlx_error_to_exec_err)?;
settings.push(access_mode.to_string());
}

if !settings.is_empty() {
let sql = format!("SET TRANSACTION {}", settings.join(" "));
sqlx::query(&sql)
.execute(&mut **conn)
.map_err(sqlx_error_to_exec_err)?;
}
Ok(())
}
Expand Down
30 changes: 14 additions & 16 deletions src/driver/sqlx_postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ use tracing::instrument;

use crate::{
AccessMode, ConnectOptions, DatabaseConnection, DatabaseConnectionType, DatabaseTransaction,
DbBackend, IsolationLevel, QueryStream, Statement, TransactionError, debug_print, error::*,
executor::*,
IsolationLevel, QueryStream, Statement, TransactionError, debug_print, error::*, executor::*,
};

use super::sqlx_common::*;
Expand Down Expand Up @@ -328,23 +327,22 @@ pub(crate) async fn set_transaction_config(
isolation_level: Option<IsolationLevel>,
access_mode: Option<AccessMode>,
) -> Result<(), DbErr> {
let mut settings = Vec::new();

if let Some(isolation_level) = isolation_level {
let stmt = Statement {
sql: format!("SET TRANSACTION ISOLATION LEVEL {isolation_level}"),
values: None,
db_backend: DbBackend::Postgres,
};
let query = sqlx_query(&stmt);
conn.execute(query).await.map_err(sqlx_error_to_exec_err)?;
settings.push(format!("ISOLATION LEVEL {isolation_level}"));
}

if let Some(access_mode) = access_mode {
let stmt = Statement {
sql: format!("SET TRANSACTION {access_mode}"),
values: None,
db_backend: DbBackend::Postgres,
};
let query = sqlx_query(&stmt);
conn.execute(query).await.map_err(sqlx_error_to_exec_err)?;
settings.push(access_mode.to_string());
}

if !settings.is_empty() {
let sql = format!("SET TRANSACTION {}", settings.join(" "));
sqlx::query(&sql)
.execute(&mut **conn)
.await
.map_err(sqlx_error_to_exec_err)?;
}
Ok(())
}
Expand Down
Loading