fix: add auth + validation to user routes, restrict admin role in registration - #11562
Open
laurentketterle-hub wants to merge 1 commit into
Open
Conversation
…istration - Add Zod validation (createUserSchema) for POST /api/users - Add authMiddleware to GET and POST /api/users routes - Remove 'admin' from registerSchema role options - Create validators/user.js with proper schema Fixes privilege escalation via unauthenticated POST /api/users and data exposure via unauthenticated GET /api/users. Refs SecureBananaLabs#11398, closes SecureBananaLabs#11561
Author
|
I claim this bounty. PR ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Closes #11561
Refs #11398
Changes
1. Created
2. Updated
3. Updated
4. Updated
Security Impact
Verification