fix(proposals): require authentication on POST /api/proposals - #11563
Open
aguayosanti99-design wants to merge 1 commit into
Open
fix(proposals): require authentication on POST /api/proposals#11563aguayosanti99-design wants to merge 1 commit into
aguayosanti99-design wants to merge 1 commit into
Conversation
The POST /api/proposals endpoint was accessible without a valid JWT, allowing any unauthenticated request to create proposals. Add authMiddleware to the route so only authenticated users can submit proposals. The GET endpoint remains publicly accessible. Closes SecureBananaLabs#2773
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
POST /api/proposalsendpoint atapps/api/src/routes/proposalRoutes.jswas missingauthMiddleware, allowing unauthenticated users to submit proposals to any job listing.Root cause
No bearer-token validation was applied to the POST handler.
Fix
Added
authMiddlewareso only requests with a valid JWT can create proposals. TheGET /api/proposalsendpoint is intentionally left public.Tests
Added
apps/api/src/tests/proposals.test.jswith two cases:POSTreturns401GETreturns200Closes #2773