chore(lints): warn on all, deny correctness and suspicious, normalize allow priorities - #9
Merged
Merged
Conversation
… allow priorities
This crate is a single package (no workspace members), so `[lints]`
here is the effective config with nothing to inherit and no member
table that could silently replace it.
Three gaps against the fleet recipe:
- the `all` group was absent entirely, so only `pedantic` was raised
above clippy's defaults;
- `correctness` and `suspicious` sat at clippy's default `warn` rather
than `deny`, so a member of either group would have passed a plain
`cargo clippy`;
- `cast_precision_loss` was the one pragmatic cast allow missing.
The individual allows were also written bare, which leaves them at
priority 0 — safe while every group sat at -1, but it stops being safe
the moment a group is added at priority 0. Rewriting them as
`{ level = "allow", priority = 1 }` makes the ordering explicit instead
of incidental.
Nothing lit up: `cargo build`, `cargo test` (89 passed across 33
binaries), `cargo clippy --all-targets -- -D warnings` and
`cargo fmt --check` are clean on the stricter config, with no
production code changed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
h4x0r
force-pushed
the
chore/workspace-lints-canonical
branch
from
August 6, 2026 00:11
56e0908 to
44575d4
Compare
h4x0r
marked this pull request as ready for review
August 6, 2026 00:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fleet-wide
workspace.lintssweep: bring this repo's clippyconfiguration up to the canonical recipe in
CLAUDE.core.md.What was verified before changing anything
The sweep's earlier rounds were twice wrong in the direction of comfort,
both times because a Cargo member with its own
[lints]table replacesworkspace inheritance rather than extending it — so a root-only check
scores a repo compliant while a member runs with no lints at all. Every
member's effective config was read here, not just the root.
The "zero production panic sites" claim was also re-derived rather than
taken on trust:
.unwrap(),.expect(...),panic!,unreachable!,todo!and slicing were scanned across everysrc/tree, with each hittraced to either a
#[cfg(test)]module or a documented, feature-gatedtest-only module.
Verification
cargo build,cargo test,cargo clippy --all-targets -- -D warningsand
cargo fmt --checkall pass on the stricter config. No productioncode changed — nothing lit up.
🤖 Generated with Claude Code