ci: repin fleet-ci to pick up the path-dependency self-test fix - #7
Merged
Conversation
This repo's `Single-checkout buildability` check has been red on main for a
reason that is not a defect in this repo:
error: 1 manifest found but zero path dependencies extracted -- the
extractor is not reading dependency tables, so this check is inert.
That guard failed any repo yielding zero path dependencies, on the reasoning
that a silently-broken extractor and a genuinely clean repo look identical. The
worry was right, the test was wrong: this is a single-crate repo that
legitimately has none, so it went red for having nothing to find.
The guard now answers the same worry with a self-test — the extractor is run
against a fixture carrying a known path dependency in every table shape it
claims to handle, so "zero found" here means zero are there. Fixed upstream and
verified with a four-way control, including that a repo with an ESCAPING path
dependency still exits 1.
Only the pinned SHA changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo's
Single-checkout buildabilitycheck has been red on main for areason that is not a defect in this repo:
That guard failed any repo yielding zero path dependencies, on the reasoning
that a silently-broken extractor and a genuinely clean repo look identical. The
worry was right, the test was wrong: this is a single-crate repo that
legitimately has none, so it went red for having nothing to find.
The guard now answers the same worry with a self-test — the extractor is run
against a fixture carrying a known path dependency in every table shape it
claims to handle, so "zero found" here means zero are there. Fixed upstream and
verified with a four-way control, including that a repo with an ESCAPING path
dependency still exits 1.
Only the pinned SHA changes.