fix: add the Apache-2.0 LICENSE the manifest already declares - #9
Merged
Conversation
The repo carried no licence file of any name while Cargo.toml declared license = "Apache-2.0" and docs/terms.md linked readers to blob/main/LICENSE, which 404'd. The crate has been published on crates.io since 0.1.0 with a licence claim nothing in the repo backed. Text is byte-identical to the rest of the fleet (md5 3b83ef96387f14655fc854ddc3c6bd57), copied from the sibling forensic-vfs repo. Typed fix: rather than chore: so release-plz cuts a patch release -- the published .crate files for 0.1.0 and 0.1.1 do not contain the licence, and only a new version fixes that for anyone consuming it from the registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forensic-vfs-mounthad no licence file of any name while:Cargo.tomldeclaredlicense = "Apache-2.0",docs/terms.mdtold readers the crate is released under the ApacheLicense 2.0 and linked them to
blob/main/LICENSE— a 404,licence claim.
This adds the file. The text is byte-identical to the rest of the fleet
(
md5 3b83ef96387f14655fc854ddc3c6bd57), copied from the siblingforensic-vfsrepo, so the licence surface stays uniform across the 93repos.
Why
fix:and notchore:Deliberate, so release-plz cuts a patch release. The published
.cratearchives for 0.1.0 and 0.1.1 do not contain the licence — cargo only bundles
a
LICENSEthat exists at package time — so the repo being correct does notby itself fix anything for a consumer pulling from the registry. Only a new
version does.
Not verified here: this host has no
cargo, so I could not runcargo package --listto demonstrate the file lands in the archive. Cargoincluding a root
LICENSEwhen the manifest has noincludelist isdocumented behaviour, not something I measured.
Adjacent, deliberately left alone
CI / License / Release / Sponsor. Adding a lone License badge to a README
with no others would look worse than none; it wants doing as one change.
rust-version = "1.85"on a published library, against the fleet rule thatlibraries hold a low CI-verified floor (1.75/1.80). The crate is
edition = "2021", so 1.85 may well be over-declared — but that is a claimto test by compiling, not to edit on a hunch.