refactor(mem): use memf-core's RangedPhysMem instead of a local copy - #17
Merged
Conversation
memf-core 0.2.4 exports `RangedPhysMem`, so the wrapper this crate grew for the netstat seam tests is redundant -- 23 lines, identical in shape to the one memf-windows carried privately until the same release deleted it. The wrapper exists because `SyntheticPhysMem` advertises no ranges and `PhysicalMemoryProvider::total_size` sums them, so it is zero and any physical scan traverses `(0, 0)`. Both netstat tests still pass against the exported type, including the one that needs a scan to actually run and find nothing. `cargo vet --locked` needed the publisher cache refreshed: the `[[trusted.memf-core]]` record was already present and correct, but imports.lock had no publisher entry for 0.2.4, and `--locked` forbids fetching one. Publishing a new version of one of our own crates reddens vet in every consumer until that cache is refreshed in the same commit as the bump. Full workspace: 212 suites, 0 failures; fmt, clippy and vet clean.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memf-core 0.2.4 exports
RangedPhysMem, so the wrapper this crate grew for the netstat seam tests is redundant — 23 lines, identical in shape to the one memf-windows carried privately until the same release deleted it. Both copies are now gone.The wrapper existed because
SyntheticPhysMemadvertises no ranges andPhysicalMemoryProvider::total_sizesums them — so it is zero, and any physical scan traverses(0, 0)and sees nothing. Both netstat tests still pass against the exported type, including the one that needs a scan to actually run and find nothing.cargo vet --lockedneeded the publisher cache refreshed: the[[trusted.memf-core]]record was already present and correct, butimports.lockhad no publisher entry for 0.2.4 and--lockedforbids fetching one. Publishing a new version of one of our own crates reddens vet in every consumer until that cache is refreshed alongside the bump.Verification —
cargo fmt --all -- --checkclean ·cargo clippy --workspace --lib --bins -- -D warningsclean ·cargo test --workspace212 suites, 0 failures ·cargo vet --lockedsucceeds