Skip to content

Conversation

@sweatbuckets
Copy link
Contributor

@sweatbuckets sweatbuckets commented Jan 25, 2026

  1. #⃣ 연관된 이슈
    • 관련 이슈를 명시해주세요.
    • 예: #이슈번호#이슈번호
  2. 📝 작업 내용
    • 응답구조 간소화
  3. 📸 스크린샷 (선택)
    • 작업 내용을 시각적으로 표현할 스크린샷을 포함하세요.
  4. 💬 리뷰 요구사항 (선택)
    • 리뷰어가 특히 검토해주었으면 하는 부분이 있다면 작성해주세요.
    • 예: "메서드 XXX의 이름을 더 명확히 하고 싶은데, 좋은 아이디어가 있으신가요?"

Summary by CodeRabbit

  • Refactor
    • Updated member notice API response format to implement cursor-based pagination. The restructured response now includes pagination availability status and cursor positioning information to provide improved list navigation and optimize the scrolling experience for browsing member notifications.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 25, 2026

📝 Walkthrough

Walkthrough

The changes refactor the member notice pagination response structure, replacing a list-based wrapper with a cursor-based scroll pagination wrapper across the controller, service, and data transfer object layers.

Changes

Cohort / File(s) Summary
Pagination Response Refactoring
src/main/java/cc/backend/notice/controller/MemberNoticeController.java, src/main/java/cc/backend/notice/dto/MemberNoticeResponseDTO.java, src/main/java/cc/backend/notice/service/MemberNoticeService.java
Replaced MemberNoticeListDTO with MemberNoticeScrollDTO to support cursor-based pagination. Updated method return types and response construction across service and controller layers. New scroll structure includes memberNotices, hasNext, nextCursorId, and nextCursorCreatedAt fields. Removed unused imports from controller.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 With cursor in paw, we hop through the list,
No more batches bundled—just infinite scroll bliss!
The notices now glide with positions so clear,
Next page awaits gently, no jumping to fear.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The pull request description uses the required template structure but lacks critical information: no related issue is specified (placeholder remains), and the work description is minimal ('응답구조 간소화') without details about the DTO changes or rationale. Specify the related issue number(s) and expand the work description to explain what changed (MemberNoticeListDTO → MemberNoticeScrollDTO) and why this simplification improves the pagination response.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title '[FIX] 알림 페이지네이션 DTO 수정' directly describes the main change: fixing and modifying the notification pagination DTO structure, which aligns with the changeset that replaces MemberNoticeListDTO with MemberNoticeScrollDTO.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/main/java/cc/backend/notice/service/MemberNoticeService.java`:
- Around line 67-68: In MemberNoticeService, remove the stray semicolon before
the closing brace after the builder call (the `;}` sequence) so the method/block
ends with a plain `}`; locate the builder chain around the .build() call in the
MemberNoticeService class and delete the extraneous semicolon that immediately
precedes the closing brace.

Comment on lines +67 to +68
.build()
;}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor formatting issue: extraneous semicolon before closing brace.

Line 68 has ;} which should just be }.

Proposed fix
-                .build()
-                ;}
+                .build();
+    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.build()
;}
.build();
}
🤖 Prompt for AI Agents
In `@src/main/java/cc/backend/notice/service/MemberNoticeService.java` around
lines 67 - 68, In MemberNoticeService, remove the stray semicolon before the
closing brace after the builder call (the `;}` sequence) so the method/block
ends with a plain `}`; locate the builder chain around the .build() call in the
MemberNoticeService class and delete the extraneous semicolon that immediately
precedes the closing brace.

@sweatbuckets sweatbuckets merged commit ec90b01 into develop Jan 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants