-
Notifications
You must be signed in to change notification settings - Fork 1
[FIX] 알림 페이지네이션 DTO 수정 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changes refactor the member notice pagination response structure, replacing a list-based wrapper with a cursor-based scroll pagination wrapper across the controller, service, and data transfer object layers. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/main/java/cc/backend/notice/service/MemberNoticeService.java`:
- Around line 67-68: In MemberNoticeService, remove the stray semicolon before
the closing brace after the builder call (the `;}` sequence) so the method/block
ends with a plain `}`; locate the builder chain around the .build() call in the
MemberNoticeService class and delete the extraneous semicolon that immediately
precedes the closing brace.
| .build() | ||
| ;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formatting issue: extraneous semicolon before closing brace.
Line 68 has ;} which should just be }.
Proposed fix
- .build()
- ;}
+ .build();
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .build() | |
| ;} | |
| .build(); | |
| } |
🤖 Prompt for AI Agents
In `@src/main/java/cc/backend/notice/service/MemberNoticeService.java` around
lines 67 - 68, In MemberNoticeService, remove the stray semicolon before the
closing brace after the builder call (the `;}` sequence) so the method/block
ends with a plain `}`; locate the builder chain around the .build() call in the
MemberNoticeService class and delete the extraneous semicolon that immediately
precedes the closing brace.
#이슈번호,#이슈번호Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.