Skip to content

Conversation

@sweatbuckets
Copy link
Contributor

@sweatbuckets sweatbuckets commented Jan 25, 2026

  1. #⃣ 연관된 이슈
    • 관련 이슈를 명시해주세요.
    • 예: #이슈번호#이슈번호
  2. 📝 작업 내용
    • [get] /photoAlbums/${prodId} 에 amateurShowId 추가
    • [get] /photoAlbums/member/${prodId} 혹은 [get] /photoAlbums/member/${prodId}/shows?page=0&size=20 두개 모두 “극단 이름” 정보 performerName 필드 추가
  3. 📸 스크린샷 (선택)
    • 작업 내용을 시각적으로 표현할 스크린샷을 포함하세요.
  4. 💬 리뷰 요구사항 (선택)
    • 리뷰어가 특히 검토해주었으면 하는 부분이 있다면 작성해주세요.
    • 예: "메서드 XXX의 이름을 더 명확히 하고 싶은데, 좋은 아이디어가 있으신가요?"

Summary by CodeRabbit

  • New Features
    • Photo album responses now include amateur show identifiers across multiple endpoints for better data association.
    • Performer show listings now display performer names in responses.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 25, 2026

📝 Walkthrough

Walkthrough

This pull request adds two new fields to data transfer objects: performerName to PerformerShowListResponseDTO and amateurShowId to four PhotoAlbum-related DTOs. Service methods are updated to populate these fields when constructing responses.

Changes

Cohort / File(s) Summary
PerformerShow Response DTO
src/main/java/cc/backend/photoAlbum/dto/PerformerShowListResponseDTO.java
Added performerName field of type String with Schema annotation for Korean label "공연진 이름"
PhotoAlbum Response DTOs
src/main/java/cc/backend/photoAlbum/dto/PhotoAlbumResponseDTO.java
Added amateurShowId field of type Long to four nested DTOs: PhotoAlbumResultDTO, PhotoAlbumResultWithPresignedUrlDTO, SinglePhotoAlbumDTO, and MemberPhotoAlbumDTO
Service Implementation
src/main/java/cc/backend/photoAlbum/service/PhotoAlbumServiceImpl.java
Updated five service methods to populate new fields: createPhotoAlbum, getPhotoAlbum, getPhotoAlbumList, updatePhotoAlbum, getAllRecentPhotoAlbumList, and getPerformerShows now include amateurShowId and performerName respectively

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • PR #125: Modifies PhotoAlbumServiceImpl.getPhotoAlbumList with overlapping code area; complements the amateurShowId propagation changes
  • PR #135: Updates PhotoAlbumResponseDTO and service layer with related DTO field additions and show-listing logic
  • PR #123: Modifies PhotoAlbumServiceImpl and MemberPhotoAlbumDTO/getAllRecentPhotoAlbumList with overlapping scope

Suggested reviewers

  • yhi9839

Poem

🐰 A rabbit hops through data fields so bright,
Adding names and IDs with careful might,
PerformerName and amateurShowId appear,
DTOs enriched, the structure now clear! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title '[FIX] 프론트 요청 수정' translates to '[FIX] Fix frontend request' and is overly vague. It doesn't specify what changes were made, making it unclear for teammates scanning the PR history. Use a more specific title that describes the actual changes, such as '[FIX] Add amateurShowId and performerName to photo album endpoints' to clearly communicate the primary changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required work content section with specific API endpoint changes and field additions. The related issues section acknowledges no linked issue but includes template guidance.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sweatbuckets sweatbuckets merged commit 3df6f34 into develop Jan 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants