Conversation
| // TODO: delegate to TxEnv::from_recovered_tx(tx, sender) once seismic-evm | ||
| // rev is bumped to include the FromRecoveredTx<TxSeismic> impl. | ||
| // See https://github.com/SeismicSystems/seismic-evm/pull/42 | ||
| SeismicTypedTransaction::Seismic(tx) => TxEnv { |
There was a problem hiding this comment.
flagging this TODO in case someone reads this from the future
|
Refactors FromRecoveredTx implementation to delegate to TxEnv for standard transaction types, reducing code duplication. Phase 1 LGTM — The refactoring properly delegates standard transaction types to |
Same fix as that from SeismicSystems/seismic-evm#42
Not sure if there was an issue here, but its just unnecessary duplicate code that is likely to contain a bug like it did in evm.