Skip to content

fix: Code override.#367

Closed
HenryMBaldwin wants to merge 3 commits intoseismicfrom
h/fix-critical-code-override
Closed

fix: Code override.#367
HenryMBaldwin wants to merge 3 commits intoseismicfrom
h/fix-critical-code-override

Conversation

@HenryMBaldwin
Copy link
Copy Markdown
Contributor

No description provided.

@HenryMBaldwin HenryMBaldwin requested a review from cdrappi as a code owner April 7, 2026 18:30
@HenryMBaldwin HenryMBaldwin force-pushed the h/fix-critical-code-override branch from b762670 to c042ad7 Compare April 7, 2026 22:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Updates seismic-evm dependency and adds code override rejection with comprehensive test coverage.

Phase 2

  • Cargo.lock:2101,3934,3952,6228,6265,12204,12720 — Multiple dependency downgrades (socket2 0.6.1→0.5.10, windows-sys 0.59.0→0.48.0, etc.) alongside the seismic-evm update. While likely necessary for compatibility, verify these downgrades don't introduce security vulnerabilities or missing features that the codebase relies on.

Phase 3

  • crates/seismic/rpc/src/eth/ext.rs:197 — Extra blank line added with no functional change.

The error handling implementation looks solid — properly integrated into the existing error system with appropriate JSON-RPC mapping. The test coverage is comprehensive, hitting all three RPC endpoints that accept state overrides (eth_call, eth_estimateGas, eth_simulateV1). Code override rejection is a reasonable security measure for Seismic's privacy model.

LGTM — the functionality is correctly implemented and well-tested.

@samlaf
Copy link
Copy Markdown
Contributor

samlaf commented Apr 8, 2026

Closing in favor of #332

@samlaf samlaf closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants