fix: isolate refunded deposits from validator withdrawal queue#151
Open
matthias-wright wants to merge 1 commit intomainfrom
Open
fix: isolate refunded deposits from validator withdrawal queue#151matthias-wright wants to merge 1 commit intomainfrom
matthias-wright wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed deposit requests have to be handled with care, because the deposit contract burns deposited funds.
If a deposit fails validation, a matching withdrawal request is queued to avoid loss of funds.
Currently, all of these withdrawal requests are grouped by the validator's public key. If an invalid deposit request triggered a withdrawal, and the same validator initiates another withdrawal, then those two withdrawals will be merged. This is not desirable, since the invalid deposit request might have different withdrawal credentials.
Changes: