1.14.1 to master (#4287)

* update 1.14.0 community bundle for OpenShift

* fix workflow on red hat image scan process (#4259)

* fix workflow on red hat image scan process

* default to rclone storage initializer for openshift community operator

* update storage initializer images to align with OpenShift requirements (+ rclone upgrade)

* certified operator: create bundle (step 1)

* certified operator: pin images (step 2)

* finalize OpenShift releases

* final version fix

* add changelog for 1.14.0 and 1.14.1

CHANGELOG.md

@@ -4,6 +4,107 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [v1.14.1](https://github.com/SeldonIO/seldon-core/compare/v1.14.0...v1.14.1)
+
+> 17 August 2022
+
+- Added fix for clashing zombie webhook [`#4265`](https://github.com/SeldonIO/seldon-core/pull/4265)
+- fix workflow on red hat image scan process [`#4259`](https://github.com/SeldonIO/seldon-core/pull/4259)
+- Make verbosity configurable and not leak sensitive values [`#4249`](https://github.com/SeldonIO/seldon-core/pull/4249)
+- Make verbosity configurable and not leak sensitive values [`#4249`](https://github.com/SeldonIO/seldon-core/pull/4249)
+- Added fix for webhook issues on 1.12.0 [`#4256`](https://github.com/SeldonIO/seldon-core/pull/4256)
+- Update stalebot.yml [`#4250`](https://github.com/SeldonIO/seldon-core/pull/4250)
+- Adding prepackaged server separate pod instructions [`#4238`](https://github.com/SeldonIO/seldon-core/pull/4238)
+- doc: add util comment && identation [`#4242`](https://github.com/SeldonIO/seldon-core/pull/4242)
+- Adding stalebot for issues and PRs with defaults [`#4232`](https://github.com/SeldonIO/seldon-core/pull/4232)
+- Fixed trailing dash created from helm split resources [`#4230`](https://github.com/SeldonIO/seldon-core/pull/4230)
+- Fix Typo in Readme.md [`#4228`](https://github.com/SeldonIO/seldon-core/pull/4228)
+- enh: Add support to configure PrepackedTriton with no storage initialiser [`#4216`](https://github.com/SeldonIO/seldon-core/pull/4216)
+- Added fix for removed guard on webhook [`#4218`](https://github.com/SeldonIO/seldon-core/pull/4218)
+- fixes foldering of the gpt2 minio notebook [`#4197`](https://github.com/SeldonIO/seldon-core/pull/4197)
+- Allow leader election controls for manager [`#4211`](https://github.com/SeldonIO/seldon-core/pull/4211)
+- factored out parse_args [`#4213`](https://github.com/SeldonIO/seldon-core/pull/4213)
+- upgrade pip, conda and setuptools in s2i image [`#4210`](https://github.com/SeldonIO/seldon-core/pull/4210)
+- Fix logging args.grpc_workers [`#4212`](https://github.com/SeldonIO/seldon-core/pull/4212)
+- renamed server_[123]_func to server_[rest|grpc|custom]_func [`#4214`](https://github.com/SeldonIO/seldon-core/pull/4214)
+- typo fix in logging bind_address of gRPC server [`#4200`](https://github.com/SeldonIO/seldon-core/pull/4200)
+- fix metadata [`#4207`](https://github.com/SeldonIO/seldon-core/pull/4207)
+- typo fix in logging number of gRPC threads used [`#4194`](https://github.com/SeldonIO/seldon-core/pull/4194)
+- typo fix in logging number of gRPC workers [`#4195`](https://github.com/SeldonIO/seldon-core/pull/4195)
+- fix link to minio example in triton page [`#4196`](https://github.com/SeldonIO/seldon-core/pull/4196)
+- Added 1.15.0-dev tag [`#4174`](https://github.com/SeldonIO/seldon-core/pull/4174)
+- add missing yaml  styling for snippets [`#4170`](https://github.com/SeldonIO/seldon-core/pull/4170)
+- update rest_predict_seldon hardcoded version in route [`#4161`](https://github.com/SeldonIO/seldon-core/pull/4161)
+- certified operator: create bundle (step 1) [`602b4c2`](https://github.com/SeldonIO/seldon-core/commit/602b4c2550a3c95fbbc886256e21cf9aa7efad0d)
+- update 1.14.0 community bundle for OpenShift [`05ec72b`](https://github.com/SeldonIO/seldon-core/commit/05ec72bd6b95f9239a60d23af163ac6b0bb8b9e1)
+- release 1.14.1 [`eefa9e4`](https://github.com/SeldonIO/seldon-core/commit/eefa9e4d58b0cde6a4b94a73c15790e41e746c7a)
+
+#### [v1.14.0](https://github.com/SeldonIO/seldon-core/compare/v1.13.1...v1.14.0)
+
+> 17 June 2022
+
+- Fixed operator redhat image [`#4157`](https://github.com/SeldonIO/seldon-core/pull/4157)
+- fix broken mlflow model build [`#4155`](https://github.com/SeldonIO/seldon-core/pull/4155)
+- Bump MLServer version to 1.1.0 [`#4148`](https://github.com/SeldonIO/seldon-core/pull/4148)
+- Upgrade to k8s 0.23 APIs, remove v1beta1 as default, upgrade KEDA [`#4136`](https://github.com/SeldonIO/seldon-core/pull/4136)
+- Create graph-modes.md [`#4144`](https://github.com/SeldonIO/seldon-core/pull/4144)
+- Fix typo in error message for Anchor tabular [`#4145`](https://github.com/SeldonIO/seldon-core/pull/4145)
+- fix transport missing in executor [`#4107`](https://github.com/SeldonIO/seldon-core/pull/4107)
+- fix alibi tests [`#4142`](https://github.com/SeldonIO/seldon-core/pull/4142)
+- Broken docs test fix removing reference to Tree [`#4141`](https://github.com/SeldonIO/seldon-core/pull/4141)
+- Fix. Ensemble model. Previouse not saved data in jagear. Working with Jagear and Istio [`#4139`](https://github.com/SeldonIO/seldon-core/pull/4139)
+- Add optional manual commit to seldon kafka server [`#4117`](https://github.com/SeldonIO/seldon-core/pull/4117)
+- update kind [`#4135`](https://github.com/SeldonIO/seldon-core/pull/4135)
+- use alternative multiprocessing library if USE_MULTIPROCESS_PACKAGE i… [`#4114`](https://github.com/SeldonIO/seldon-core/pull/4114)
+- upgrade alibi explain to 0.7.0 [`#4112`](https://github.com/SeldonIO/seldon-core/pull/4112)
+- Update cache folder and bump MLServer image [`#4094`](https://github.com/SeldonIO/seldon-core/pull/4094)
+- Adding protocol info to executor payload logging worker [`#4077`](https://github.com/SeldonIO/seldon-core/pull/4077)
+- Don't hardcode UID for Triton containers [`#4099`](https://github.com/SeldonIO/seldon-core/pull/4099)
+- Sorted metric tags to avoid duplicate prom data with gRPC requests [`#4006`](https://github.com/SeldonIO/seldon-core/pull/4006)
+- respect envSecretRefName coming from helm values [`#4089`](https://github.com/SeldonIO/seldon-core/pull/4089)
+- minor type fix [`#4086`](https://github.com/SeldonIO/seldon-core/pull/4086)
+- Huggingface optimum prepackaged server [`#4081`](https://github.com/SeldonIO/seldon-core/pull/4081)
+- Adding configuration for feature level drift metrics [`#4079`](https://github.com/SeldonIO/seldon-core/pull/4079)
+- Fixed random seed for anchor explanation [`#4078`](https://github.com/SeldonIO/seldon-core/pull/4078)
+- Re-setting numpy random seed to zero on every explain request [`#4076`](https://github.com/SeldonIO/seldon-core/pull/4076)
+- Pass through model name env var for MLServer [`#4069`](https://github.com/SeldonIO/seldon-core/pull/4069)
+- Update seldon-deployment.rst [`#4075`](https://github.com/SeldonIO/seldon-core/pull/4075)
+-  Adding tests to explicitly state expected behaviour of v2 protocol chaining in REST [`#4061`](https://github.com/SeldonIO/seldon-core/pull/4061)
+- add prometheus operator docs [`#4038`](https://github.com/SeldonIO/seldon-core/pull/4038)
+- change versions we test upgrade of operator from [`#4066`](https://github.com/SeldonIO/seldon-core/pull/4066)
+- lock jager operator helm chart to fix integration tests [`#4064`](https://github.com/SeldonIO/seldon-core/pull/4064)
+- Protocol specific ready checkers [`#4028`](https://github.com/SeldonIO/seldon-core/pull/4028)
+- fix(executer): Forward parameters while chaining models via kfserve grpc [`#4054`](https://github.com/SeldonIO/seldon-core/pull/4054)
+- Outlier example poetry [`#4055`](https://github.com/SeldonIO/seldon-core/pull/4055)
+- fix removal of request logger to fix CI [`#4044`](https://github.com/SeldonIO/seldon-core/pull/4044)
+- Enabling optional grpc server on python level only [`#4027`](https://github.com/SeldonIO/seldon-core/pull/4027)
+- Removed request logger from github security workflows [`#4039`](https://github.com/SeldonIO/seldon-core/pull/4039)
+- Python request logger example component deprication and removal [`#4016`](https://github.com/SeldonIO/seldon-core/pull/4016)
+- Extended GPT2 MLServer Pipeline Example to include post-processor [`#4035`](https://github.com/SeldonIO/seldon-core/pull/4035)
+- Updated CPP example to use latest 3.8 base image [`#4026`](https://github.com/SeldonIO/seldon-core/pull/4026)
+- allow priorityClassName for manager [`#4030`](https://github.com/SeldonIO/seldon-core/pull/4030)
+- Updating model inputs for new schema [`#4032`](https://github.com/SeldonIO/seldon-core/pull/4032)
+- Updating typings for prediction API documentation [`#4025`](https://github.com/SeldonIO/seldon-core/pull/4025)
+- Fixed Flask breaking version by werkzeug dependency limit to 2.1 [`#4018`](https://github.com/SeldonIO/seldon-core/pull/4018)
+- Update ab_test_2pods.json [`#4020`](https://github.com/SeldonIO/seldon-core/pull/4020)
+- Decompress prediction events before logging to kafka topics [`#4005`](https://github.com/SeldonIO/seldon-core/pull/4005)
+- Updated poetry environment and lockfile for Alibi Detect 0.9.0 [`#4001`](https://github.com/SeldonIO/seldon-core/pull/4001)
+- update sklearn iris example [`#3995`](https://github.com/SeldonIO/seldon-core/pull/3995)
+- Release v1.13.1 for OpenShift [`#3987`](https://github.com/SeldonIO/seldon-core/pull/3987)
+- Bumping rclone image version to 1.57.0 [`#3990`](https://github.com/SeldonIO/seldon-core/pull/3990)
+- fix example yaml file error in README.md [`#3994`](https://github.com/SeldonIO/seldon-core/pull/3994)
+- added tag for s2i python image [`#3992`](https://github.com/SeldonIO/seldon-core/pull/3992)
+- Fixing nbqa linting for latest notebook [`#3991`](https://github.com/SeldonIO/seldon-core/pull/3991)
+- support traffic settings for shadow deployment with istio [`#3780`](https://github.com/SeldonIO/seldon-core/pull/3780)
+- Issue #3968: Allow hostNetwork=true for seldon operator [`#3971`](https://github.com/SeldonIO/seldon-core/pull/3971)
+- Updating explainer docs into 0.6.4 [`#3976`](https://github.com/SeldonIO/seldon-core/pull/3976)
+- Add TLS to Kafka Consumer and also add Kafka + KEDA + TLS example [`#3977`](https://github.com/SeldonIO/seldon-core/pull/3977)
+- Merging 1.13.1 changelog and update to 1.14.0-dev images [`#3962`](https://github.com/SeldonIO/seldon-core/pull/3962)
+- Bumping rclone image version to 1.57.0 (#3990) [`#3973`](https://github.com/SeldonIO/seldon-core/issues/3973)
+- Updating changelog to 1.13.1 [`adf6c54`](https://github.com/SeldonIO/seldon-core/commit/adf6c54503da2b415800485c57c335df75be8fc5)
+- Release v1.14.0 [`158950f`](https://github.com/SeldonIO/seldon-core/commit/158950f357f740f89a4741f2a8e1c8ca9841cc54)
+- Updated changelog and docs [`8307fe3`](https://github.com/SeldonIO/seldon-core/commit/8307fe36e771a2ed4b55596706c303a92ef35b19)
+
 #### [v1.13.1](https://github.com/SeldonIO/seldon-core/compare/v1.13.0...v1.13.1)
 
 > 21 February 2022

components/.gitignore

@@ -0,0 +1 @@
+**/artifacts

components/alibi-detect-server/.gitignore

@@ -5,3 +5,4 @@ adserver.egg-info
 .coverage
 _seldon_core
 version.txt
+artifacts

components/alibi-detect-server/Dockerfile

@@ -73,4 +73,5 @@ COPY --from=builder /licenses /licenses
 # This is to have writable numba cache directory
 ENV NUMBA_CACHE_DIR /tmp/numba-cache
 
+USER 8888
 ENTRYPOINT ["python", "-m", "adserver"]

components/alibi-detect-server/Makefile

@@ -119,9 +119,13 @@ kind_load: docker-build
 #
 
 # password can be found at: https://connect.redhat.com/project/3993461/view
+scan=ospid-32ed6498-bce5-4c3b-9486-fe1c6e2582d3
+project=5e9d53076c2dde3913c2bb66
 redhat-image-scan:
 	docker pull ${REPO}/${IMAGE}:${VERSION}
 	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
 		echo $${rh_password_alibi_detect} | docker login -u unused scan.connect.redhat.com --password-stdin
-	docker tag ${REPO}/${IMAGE}:${VERSION} scan.connect.redhat.com/ospid-32ed6498-bce5-4c3b-9486-fe1c6e2582d3/${IMAGE}:${VERSION}
-	docker push scan.connect.redhat.com/ospid-32ed6498-bce5-4c3b-9486-fe1c6e2582d3/${IMAGE}:${VERSION}
+	docker tag ${REPO}/${IMAGE}:${VERSION} scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
+	docker push scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
+	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
+		preflight check container scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION} --docker-config=${HOME}/.docker/config.json --certification-project-id=${project} --pyxis-api-token=$${pyxis_api_token} --submit

components/alibi-explain-server/.gitignore

@@ -2,3 +2,4 @@ dist
 models
 test_models
 venv
+artifacts

components/alibi-explain-server/Dockerfile

@@ -63,4 +63,5 @@ COPY --from=builder /microservice /microservice
 COPY --from=builder /licenses /licenses
 COPY --from=builder /opt/conda /opt/conda
 
+USER 8888
 ENTRYPOINT ["python", "-m", "alibiexplainer"]

components/alibi-explain-server/Makefile

@@ -68,12 +68,16 @@ kind_load: docker-build
 	kind load docker-image seldonio/${IMAGE}:${VERSION} --name ${KIND_NAME}
 
 # password can be found at: https://connect.redhat.com/project/3987291/view
+scan=ospid-02f3e15b-c16f-4353-affa-61d5f3c6408b
+project=5e9c884a014eb1d2cfa8f217
 redhat-image-scan:
 	docker pull seldonio/${IMAGE}:${VERSION}
 	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
 		echo $${rh_password_alibi_explain} | docker login -u unused scan.connect.redhat.com --password-stdin
-	docker tag seldonio/${IMAGE}:${VERSION} scan.connect.redhat.com/ospid-02f3e15b-c16f-4353-affa-61d5f3c6408b/${IMAGE}:${VERSION}
-	docker push scan.connect.redhat.com/ospid-02f3e15b-c16f-4353-affa-61d5f3c6408b/${IMAGE}:${VERSION}
+	docker tag seldonio/${IMAGE}:${VERSION} scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
+	docker push scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
+	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
+		preflight check container scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION} --docker-config=${HOME}/.docker/config.json --certification-project-id=${project} --pyxis-api-token=$${pyxis_api_token} --submit
 
 clean:
 	rm -rf test_models

components/rclone-storage-initializer/Dockerfile

@@ -1,16 +1,23 @@
-FROM rclone/rclone:1.57.0
-LABEL name="Storage Initializer (rclone based)" \
+FROM rclone/rclone:1.59.1 as builder
+
+RUN mkdir /licenses && wget -O /licenses/license.txt https://raw.githubusercontent.com/rclone/rclone/master/COPYING
+
+FROM registry.access.redhat.com/ubi8/ubi-minimal
+LABEL name="Rclone Storage Initializer" \
       vendor="Seldon Technologies" \
-      version="1.8.0-dev" \
+      version="1.15.0-dev" \
       release="1" \
       summary="Storage Initializer for Seldon Core" \
       description="Allows Seldon Core to download artifacts from cloud and local storage to a local volume"
 
+COPY --from=builder /usr/local/bin/ /usr/local/bin/
+COPY --from=builder /licenses/ /licenses/
 
 ENV RCLONE_CONFIG_GS_TYPE google cloud storage
 ENV RCLONE_CONFIG_GS_ANONYMOUS true
 
 # Do not set to '2' by default, as this may leak sensitive values
 ENV RCLONE_VERBOSE 1
 
+USER 8888
 ENTRYPOINT ["rclone", "copy"]

components/rclone-storage-initializer/Makefile

@@ -13,21 +13,13 @@ docker-push:
 kind-load: docker-build
 	kind load docker-image seldonio/${IMAGE}:${VERSION} --name ${KIND_NAME}
 
-
-docker-build-redhat:
-	docker build --file=Dockerfile.redhat --force-rm=true -t seldonio/${IMAGE}-ubi8:${VERSION} .
-
-docker-push-redhat:
-	docker push seldonio/${IMAGE}-ubi8:${VERSION}
-
-kind-load-redhat:
-	kind load docker-image seldonio/${IMAGE}-ubi8:${VERSION} --name ${KIND_NAME}
-
-
 scan=ospid-622b6fcf8a65f13d3bd4172f
+project=622b6fcf8a65f13d3bd4172f
 redhat-image-scan:
-	# docker pull seldonio/${IMAGE}-ubi8:${VERSION}
+	docker pull seldonio/${IMAGE}:${VERSION}
 	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
 		echo $${rh_password_rclone_storage_initializer} | docker login -u unused scan.connect.redhat.com --password-stdin
-	docker tag seldonio/${IMAGE}-ubi8:${VERSION} scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
+	docker tag seldonio/${IMAGE}:${VERSION} scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
 	docker push scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
+	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
+		preflight check container scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION} --docker-config=${HOME}/.docker/config.json --certification-project-id=${project} --pyxis-api-token=$${pyxis_api_token} --submit

components/storage-initializer/Dockerfile

@@ -24,5 +24,4 @@ RUN yum -y update-minimal --security --sec-severity=Important --sec-severity=Cri
 RUN yum remove -y nodejs httpd
 
 USER default
-
 ENTRYPOINT ["./storage-initializer/scripts/initializer-entrypoint"]

components/storage-initializer/Makefile

@@ -15,12 +15,16 @@ kind_load: docker-build
 	kind load docker-image seldonio/${IMAGE}:${VERSION}
 
 # password can be found at: https://connect.redhat.com/project/3986991/view
+scan=ospid-dc132f00-5370-46ed-b506-737bb66d3f34
+project=5e9c7eea929b3d289e60977a
 redhat-image-scan:
 	docker pull seldonio/${IMAGE}:${VERSION}
 	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
 		echo $${rh_password_storage_initializer} | docker login -u unused scan.connect.redhat.com --password-stdin
-	docker tag seldonio/${IMAGE}:${VERSION} scan.connect.redhat.com/ospid-dc132f00-5370-46ed-b506-737bb66d3f34/${IMAGE}:${VERSION}
-	docker push scan.connect.redhat.com/ospid-dc132f00-5370-46ed-b506-737bb66d3f34/${IMAGE}:${VERSION}
+	docker tag seldonio/${IMAGE}:${VERSION} scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
+	docker push scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION}
+	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
+		preflight check container scan.connect.redhat.com/${scan}/${IMAGE}:${VERSION} --docker-config=${HOME}/.docker/config.json --certification-project-id=${project} --pyxis-api-token=$${pyxis_api_token} --submit
 
 clean:
 	rm -rf kfserving

doc/source/reference/upgrading.md

@@ -6,6 +6,41 @@ If you were running our Openshift 0.4.2 certified operator and are looking to up
 
 Make sure you also [read the CHANGELOG](./changelog.html) to see the detailed features and bug-fixes in each version.
 
+
+## Upgrading to 1.14.1
+
+### OpenShift default storage initializer
+
+In this patch release we fixed the default storage initializer used on OpenShift (both Community and Certified operators).
+The image used now is `seldonio/rclone-storage-initializer:1.14.1` which is the same as one used for the non-OpenShift releases (*).
+
+For Certified operator you will find this image defined as
+```yaml
+- name: RELATED_IMAGE_STORAGE_INITIALIZER
+  value: registry.connect.redhat.com/seldonio/rclone-storage-initializer@sha256:a0280c13136dcc870194af72630b9d2f7fc8bcff4edb54dd3bfbce36741af50c
+```
+in the CSV. This is the same image, just coming from the Red Hat registry.
+
+If you prefer or need to keep using previous storage initializer you can set for Community Operator
+```yaml
+- name: RELATED_IMAGE_STORAGE_INITIALIZER
+  value: kfserving/storage-initializer:v0.6.1
+```
+or
+```yaml
+- name: RELATED_IMAGE_STORAGE_INITIALIZER
+  value: registry.connect.redhat.com/seldonio/storage-initializer@sha256:52f1e1901fc5de0734515f136847eeb698d48903cf7b6b1cbf273d303bb9029c
+```
+for the Certified one.
+
+(*) Non-OpenShift releases defaulted to Rclone-based storage initializer in Seldon Core version 1.8.
+
+### Rclone Storage Initializer
+
+Rclone storage initializer image is now based on Red Hat's Universal Base Image (UBI8).
+This is not breaking change.
+
+
 ## Upgrading to 1.14
 
 ### CRD V1

examples/models/mean_classifier/.gitignore

@@ -0,0 +1 @@
+artifacts

examples/models/mean_classifier/Makefile

@@ -22,12 +22,12 @@ kind_load: build
 
 # https://connect.redhat.com/project/4035711/view
 scan=ospid-c90fdfe6-d054-4598-baa8-7f7aac3ed63a
+project=5ea15983ebed1415210b4b26
 redhat-image-scan:
 	docker pull ${IMAGE_BASE}:${VERSION}
 	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
 		echo $${rh_password_mock_model} | docker login -u unused scan.connect.redhat.com --password-stdin
 	docker tag ${IMAGE_BASE}:${VERSION} scan.connect.redhat.com/${scan}/${IMAGE_NAME_BASE}:${VERSION}
 	docker push scan.connect.redhat.com/${scan}/${IMAGE_NAME_BASE}:${VERSION}
-
-
-
+	source ~/.config/seldon/seldon-core/redhat-image-passwords.sh && \
+		preflight check container scan.connect.redhat.com/${scan}/${IMAGE_NAME_BASE}:${VERSION} --docker-config=${HOME}/.docker/config.json --certification-project-id=${project} --pyxis-api-token=$${pyxis_api_token} --submit