-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] Use Chrome instead of Firefox for internal Remote tests #16419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[py] Use Chrome instead of Firefox for internal Remote tests #16419
Conversation
I found the weirdest Chrome issue while working on this PR. Any file the test tries to download gets downloaded as an *.html file instead of the correct file extension. I can't reproduce it when manually launching the same browser... but when driven by chromedriver, it renames the files (like I have the tests altered to compensate for this, but I have no idea what is going on. |
…HQ#16433) Update pinned browser versions Co-authored-by: Selenium CI Bot <[email protected]> Co-authored-by: Diego Molina <[email protected]>
User description
🔗 Related Issues
Fixes #16417
💥 What does this PR do?
This PR updates the internal Python test suite and CI job to use Chrome instead of Firefox for Remote tests.
This also updates the
driver
fixture to cleanup downloaded files between tests if running a Remote WebDriver so we don't leak between tests if we don't close the browser.🔄 Types of changes
PR Type
Tests
Description
Switch Remote WebDriver tests from Firefox to Chrome
Update test fixtures to use
chromium_options
instead offirefox_options
Modify CI workflow to run remote tests with Chrome browser
Change default Remote options configuration from Firefox to Chrome
Diagram Walkthrough
File Walkthrough
conftest.py
Update Remote driver default options to Chrome
py/conftest.py
remote
driver default options fromFirefoxOptions
toChromeOptions
(
goog:chromeOptions
)driver
ci-python.yml
Switch CI remote tests to Chrome browser
.github/workflows/ci-python.yml
chrome
instead offirefox
for remotetests
remote_connection_tests.py
Switch Remote test fixtures from Firefox to Chrome
py/test/selenium/webdriver/remote/remote_connection_tests.py
firefox_options
fixture withchromium_options
in timeouttests
remote_custom_locator_tests.py
Update custom locator test to use Chrome options
py/test/selenium/webdriver/remote/remote_custom_locator_tests.py
firefox_options
tochromium_options