-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[build][rb] remove unnecessary log output from windows runs #16876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
bc658a8 to
bf1b495
Compare
User description
Windows run throw a bunch of protobuf errors/warnings/info in the logs that are not needed. This should fix that.
Tagging [rb] just to get those tests run to verify.
PR Type
Bug fix
Description
Replace generic C++ standard flags with platform-specific configurations
Add Windows-specific protobuf compiler warning suppression flag
Ensure proper C++ standard compilation across Linux, macOS, and Windows
Diagram Walkthrough
File Walkthrough
.bazelrc
Platform-specific C++ standards and Windows protobuf warningsuppression.bazelrc
build --cxxoptandbuild --host_cxxoptflags withplatform-specific variants
build:linuxandbuild:macosconfigurations using-std=c++17syntax
build:windowsconfiguration using/std:c++17(MSVC syntax)per_file_coptflag to suppress protobufcompiler warnings with
/w