Skip to content

Conversation

@aureliosaraiva
Copy link
Collaborator

@aureliosaraiva aureliosaraiva commented Aug 1, 2017

This is a proposal to change the way we get the code snippet in the documentation.

What this solves?

  • Resolving a snippet problem is not valid
  • Solve the problem of updating the example and do not remember to update the snippet
  • Possibility of catching snippet of controller, component, route

This project also use it.

https://github.com/miguelcobain/ember-paper
https://github.com/ef4/ember-code-snippet

If they agree, I can replicate it for all the documentation.

Copy link
Contributor

@khornberg khornberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this method and use it in other projects.
I particularly like that the code which is used to produced the view is then available to see.

app.import(app.bowerDirectory + "/highlightjs/highlight.pack.min.js");

app.import(app.bowerDirectory + "/highlightjs/styles/github-gist.css");
app.import(app.bowerDirectory + "/highlightjs/styles/hybrid.css");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If highlightjs is gone are these necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@championswimmer
Copy link
Collaborator

looks like a good way to do this

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Resolve your conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants