Merge mixed speculative decoding points on agentic curves - #695
Open
cquil11 wants to merge 4 commits into
Open
Conversation
Treat speculative decoding as point-level metadata for agentic scenarios while retaining fixed-sequence curve identity. Keep availability and run selection aligned, preserve overlapping point identity, and expose the method in bilingual tooltips. 中文:修复(推理):合并智能体场景中的投机解码点。智能体曲线不再按投机解码方式拆分,同时保持定长场景的现有曲线标识;同步可用性与运行筛选,避免重叠点丢失,并在中英文 tooltip 中展示每个点的投机解码方式。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keep performance-over-time selections and historical matches distinct for agentic MTP and standard-decoding points while preserving fixed-sequence behavior.\n\n中文:区分智能体场景中被跟踪的投机解码模式,避免 Performance Over Time 将相同拓扑的 MTP 与标准解码点合并,同时保持定长场景行为不变。
Address independent review findings across run selection, history, overview, tracking, replay, labels, and changelog matching while preserving fixed-sequence behavior.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4bf754c. Configure here.
Apply the existing agentic latest-run selector to live AI chart benchmark data so mixed decode curves cannot combine workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
agentic_traces, so one hardware/framework curve can contain MTP, EAGLE, or standard-decoding points.spec_methodon every point, include it in point-level identity, and label each agentic point as STP, MTP, or its other speculative method.?unofficialrun=overlays; verified locally through the shared transform/tooltip regression tests and Cypress overlay coverage, and on the Vercel preview with both MTP and standard-decoding point tooltips.Root cause
The dashboard used
spec_methodin the hardware key for every scenario. That assumed an entire curve used one decode method, so mixed AgentX submissions were split into separate legend lines and availability/run filters continued to treat them as distinct series.Main InferenceX repository assessment
No structural
master.yamlchange is required inSemiAnalysisAI/InferenceX. Its current agentic schema already definesspec-decodingon eachagentic-coding.search-spaceentry. The matrix generator propagates the value per job, launchers route from the per-job value, and single-node and multi-node artifact filenames already include_spec-${SPEC_DECODING}. A mixed curve can therefore be submitted under one top-level agentic config with differentspec-decodingvalues on individual search-space entries. The spec suffix must remain in job and artifact filenames because it prevents collisions; this PR removes it only from agentic display-series identity.Reference: Slack discussion
Validation
bun run lintbun run fmtbun run typecheckbun run test:unit— 3,745 tests passedbun run build— passedbun run security— reports the repository's existing 20 lockfile advisories; this PR changes no dependenciesNote
Medium Risk
Touches core chart identity, deduplication, and history API paths across inference, overview, and DB queries; incorrect merging could mis-attribute agentic points or drop comparison/history data.
Overview
Agentic traces now treat speculative decoding as point-level metadata instead of splitting curves by
spec_method.getHardwareKey, availability keys, default precision counting, overview/AgentX grouping, and changelog legend matching all omit spec suffixes foragentic_traceswhile fixed-sequence behavior stays the same.Shared
point-identityhelpers keep scatter, replay, and “track over time” distinct for overlapping STP/MTP points; agentic scatter labels and tooltips show decode mode. Newbenchmark-run-selectiondedupes agentic series by workflow run (latest chart, history, comparisons, replay, AI charts).The benchmark history API accepts
benchmarkType=agentic_traceswithout ISL/OSL; DB/history queries returnworkflow_run_id/run_started_at. Cache keys bump tobenchmark-history-v2andworkflow-info-v2.Reviewed by Cursor Bugbot for commit ee605cb. Bugbot is set up for automated code reviews on this repo. Configure here.