Show clipped benchmark rows in inference tables / 在推理表格中显示裁剪数据行 - #708
Merged
Conversation
Restore cost- and latency-clipped points when rendering inference tables while preserving chart display limits. Include clipped official and unofficial rows in visibility scopes and add component regression coverage. 中文:修复推理表格遗漏超出图表显示上限的数据行。表格恢复成本和延迟裁剪点,同时保留图表显示限制;官方与 unofficial overlay 路径均纳入可见范围并补充组件回归测试。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?unofficialrun=overlay visibility scopes$4.0/Mand TP8$7.016/Mcase plus an unofficial overlayRoot cause
The inference chart correctly retains values above its
$5/Mvisual cap inclippedDataso chart mode can draw boundary continuations. Table mode rendered onlygraph.data, however, silently omitting the B200 TP8$7.016/Mrow even though the calculator correctly consumed it from the API.Impact
Inference tables now list every measured row, including values intentionally excluded from the plotted domain. The TP8
$7.016/Mrow appears alongside TP4$4.0/M; chart axes and boundary-continuation behavior remain unchanged.Works for both official runs and
?unofficialrun=overlays.Validation
bun run fmtbun run lintbun run typecheckTZ=UTC bun run test:unit(3,731 tests passed)bun run --cwd packages/app test:e2e:quick:component(25 tests passed)DATABASE_READONLY_URLis unavailable in this environment中文说明
摘要
?unofficialrun=overlay 的可见范围均纳入裁剪点$4.0/M、TP8$7.016/M以及 unofficial overlay 场景补充组件回归测试根因
推理图表会将超过
$5/M显示上限的数值正确保留在clippedData中,以便图表模式绘制边界延伸线。但表格模式只渲染graph.data,导致 B200 TP8$7.016/M行被静默遗漏,而计算器仍会从 API 正确读取该数据。影响
推理表格现在会列出所有实测数据,包括为保持图表易读性而排除在绘图区之外的数值。TP8
$7.016/M会与 TP4$4.0/M同时显示;图表坐标轴和边界延伸线行为保持不变。官方运行和
?unofficialrun=overlay 均已覆盖。验证
bun run fmtbun run lintbun run typecheckTZ=UTC bun run test:unit(3,731 项测试通过)bun run --cwd packages/app test:e2e:quick:component(25 项测试通过)DATABASE_READONLY_URL,因此无法运行依赖数据库的推理用例Note
Low Risk
UI-only inference display logic with targeted component regression coverage; chart rendering paths are unchanged.
Overview
Inference table mode now merges
clippedDatainto the row set for official graphs and unofficial overlays before legend and filter gates, so cost- or latency-capped points (e.g. B200 TP8 above a$5/Mchart cap) appear in the table while chart plotting and display limits stay the same.Scope and stub charts also count clipped overlay and official points when building
officialScope/overlayScopeand when deciding whether overlay-only data should synthesize empty stub graphs.A Cypress case in
scatter-graph.cy.tsxasserts four table rows for clipped official and overlay cost points.Reviewed by Cursor Bugbot for commit a2fcc97. Bugbot is set up for automated code reviews on this repo. Configure here.