Skip to content

fix(ui): support multi-select kernel modes / fix(ui):支持内核模式多选 - #714

Merged
Oseltamivir merged 3 commits into
masterfrom
agent/collectivex-multi-kernel
Aug 10, 2026
Merged

fix(ui): support multi-select kernel modes / fix(ui):支持内核模式多选#714
Oseltamivir merged 3 commits into
masterfrom
agent/collectivex-multi-kernel

Conversation

@Oseltamivir

@Oseltamivir Oseltamivir commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Allow the CollectiveX kernel mode control to keep Normal and Low-latency selected together, so both series can be compared in one chart.
  • Preserve at least one selected kernel mode and keep availability filtering consistent as EP and phase change.
  • Place the calculator’s “Hide if target exceeds config range” switch directly beside its label.
  • Add unit and E2E regression coverage for multi-mode filtering and control spacing.

Validation

  • bun run lint
  • bun run fmt
  • bun run typecheck
  • CollectiveX unit tests: 36 passed
  • CollectiveX Cypress E2E: 26 passed
  • The calculator E2E suite could not load benchmark bars locally because DATABASE_READONLY_URL is unavailable; the failure occurred in suite setup before the layout assertion.

中文说明

  • CollectiveX 的内核模式控件现可同时选中“常规”和“低延迟”,便于在同一张图表中对比两类曲线。
  • 始终保留至少一种内核模式,并在切换 EP 和阶段时同步更新可用模式筛选。
  • 将计算器中的“隐藏超出配置上限的型号”开关移至标签旁边。
  • 为多模式筛选和控件间距新增单元测试与 E2E 回归测试。

验证

  • bun run lint
  • bun run fmt
  • bun run typecheck
  • CollectiveX 单元测试:36 项通过
  • CollectiveX Cypress E2E:26 项通过
  • 由于本地环境缺少 DATABASE_READONLY_URL,计算器 E2E 测试无法加载基准测试柱形图;测试在套件初始化阶段终止,尚未执行布局断言。

Note

Low Risk
UI-only chart filtering and layout changes with no auth, API, or data-layer impact.

Overview
CollectiveX replaces single-select kernel mode with multi-select: modes is an array, seriesMatchesSelection accepts any selected mode, and the mode control is toggle buttons (aria-pressed) that can show Normal and Low-latency together on one chart while blocking deselecting the last mode. Availability logic keeps the user’s mode set across EP/phase changes and only resets when the current slice has no overlap.

Throughput calculator moves the “hide SKU above config limit” switch from below the target slider to a row beside the target label (calculator-hide-over-limit-control), with a Cypress layout assertion.

Tests cover multi-mode filtering (unit) and dual-mode chart lines plus EP round-trip (E2E).

Reviewed by Cursor Bugbot for commit a1c8461. Bugbot is set up for automated code reviews on this repo. Configure here.

Allow CollectiveX users to compare normal and low-latency kernel modes together, and place the calculator config-range switch beside its label. Add regression coverage for filtering and layout behavior.

中文:支持内核模式多选
允许 CollectiveX 用户同时对比常规与低延迟内核模式,并将计算器的配置范围开关移至标签旁。新增筛选与布局行为的回归测试。
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
inferencemax-app Ready Ready Preview Aug 10, 2026 7:18am

Request Review

@Oseltamivir
Oseltamivir marked this pull request as ready for review August 10, 2026 06:53
@Oseltamivir
Oseltamivir requested a review from adibarra as a code owner August 10, 2026 06:53

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f89f0d4. Configure here.

Comment thread packages/app/src/components/collectivex/CollectiveXDisplay.tsx Outdated
Move the config-range toggle into the target interactivity header row above the slider to remove the unused vertical space. Update the layout regression assertion.

中文:压缩目标交互性控件布局
将配置范围开关移至目标交互性标题行并置于滑块上方,减少未利用的垂直空间,同时更新布局回归断言。
Keep selected kernel modes across transient empty availability and single-mode EP or phase slices. Add an E2E regression that restores a two-mode comparison after visiting a single-mode slice.

中文:保留内核模式多选偏好
在可用模式短暂为空以及切换至单模式 EP 或阶段时保留用户选择,并新增 E2E 回归测试,验证返回后可恢复双模式对比。
@Oseltamivir
Oseltamivir merged commit bc1fa04 into master Aug 10, 2026
27 checks passed
@Oseltamivir
Oseltamivir deleted the agent/collectivex-multi-kernel branch August 10, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant