fix(ui): support multi-select kernel modes / fix(ui):支持内核模式多选 - #714
Merged
Conversation
Allow CollectiveX users to compare normal and low-latency kernel modes together, and place the calculator config-range switch beside its label. Add regression coverage for filtering and layout behavior. 中文:支持内核模式多选 允许 CollectiveX 用户同时对比常规与低延迟内核模式,并将计算器的配置范围开关移至标签旁。新增筛选与布局行为的回归测试。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Oseltamivir
marked this pull request as ready for review
August 10, 2026 06:53
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f89f0d4. Configure here.
Move the config-range toggle into the target interactivity header row above the slider to remove the unused vertical space. Update the layout regression assertion. 中文:压缩目标交互性控件布局 将配置范围开关移至目标交互性标题行并置于滑块上方,减少未利用的垂直空间,同时更新布局回归断言。
Keep selected kernel modes across transient empty availability and single-mode EP or phase slices. Add an E2E regression that restores a two-mode comparison after visiting a single-mode slice. 中文:保留内核模式多选偏好 在可用模式短暂为空以及切换至单模式 EP 或阶段时保留用户选择,并新增 E2E 回归测试,验证返回后可恢复双模式对比。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
bun run lintbun run fmtbun run typecheckDATABASE_READONLY_URLis unavailable; the failure occurred in suite setup before the layout assertion.中文说明
验证
bun run lintbun run fmtbun run typecheckDATABASE_READONLY_URL,计算器 E2E 测试无法加载基准测试柱形图;测试在套件初始化阶段终止,尚未执行布局断言。Note
Low Risk
UI-only chart filtering and layout changes with no auth, API, or data-layer impact.
Overview
CollectiveX replaces single-select kernel mode with multi-select:
modesis an array,seriesMatchesSelectionaccepts any selected mode, and the mode control is toggle buttons (aria-pressed) that can show Normal and Low-latency together on one chart while blocking deselecting the last mode. Availability logic keeps the user’s mode set across EP/phase changes and only resets when the current slice has no overlap.Throughput calculator moves the “hide SKU above config limit” switch from below the target slider to a row beside the target label (
calculator-hide-over-limit-control), with a Cypress layout assertion.Tests cover multi-mode filtering (unit) and dual-mode chart lines plus EP round-trip (E2E).
Reviewed by Cursor Bugbot for commit a1c8461. Bugbot is set up for automated code reviews on this repo. Configure here.