feat(overview): merge the matrix footer into one bar and dim stale data in flight / 合并矩阵页脚为单栏并在加载中淡化旧数据 - #744
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @edwingao28's task in 5m 21s —— View job Review: overview footer merge & in-flight dimming🟢 LGTM — no blocking issues found.
I reviewed the code statically and verified it at runtime against the dev server. Static review
Runtime verification (
CI: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63cca8f8ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude finished @edwingao28's task in 1m 34s —— View job Re-review: overview footer merge & in-flight dimming🟢 LGTM — no blocking issues found. New commit
This re-review covers the delta since the prior LGTM on New test commit (
Static review of the rest — consistent with the prior pass; nothing new to flag. The Runtime verification (
CI: |
Stacked on #719 — UI/UX polish only, no behavior change to its features.
Summary
OverviewNavigationProviderexposespending; a fetch still unresolved after 150ms dims the stale matrix to 60% opacity. Cache hits and fast responses stay under the delay and never flicker. The URL-driven server filtering, hover prefetch and client cache are untouched.Test plan
bun run test:unit— 3,796 tests passbun run typecheck,bun run lint,bun run fmtcleanoverview.cy.tsagainst a fixtures dev server: same 5 pre-existing environmental failures as the unmodified feat(overview): fit the matrix on one screen and present it full screen / 一屏信息总览与全屏演示 #719 head, zero new; the zh model-scope assertion updated for the chip label with the full sentence asserted onaria-labelrows=/hwrows=correctly中文说明
基于 #719 的增量 PR——仅打磨 UI/UX,不改变其功能行为。
OverviewNavigationProvider暴露pending;请求超过 150ms 未返回时旧矩阵淡化至 60% 不透明度,缓存命中与快速响应不闪烁。URL 驱动的服务端过滤、悬停预取与客户端缓存均未改动。Note
Low Risk
Client-side overview navigation and presentation UI only; no API or data-model changes, with tests for pending state and existing navigation race handling.
Overview
Overview UI polish on top of #719: layout and loading feedback, not new filtering behavior.
The matrix card footer is one bar—methodology notes on the left, row/model scope controls as chips with count badges on the right (full counted sentences on
aria-label/title). Scope toggles use the same chip style in the footer and presentation toolbar; presentation drops the badge.The control strip matches the presenting toolbar’s three-column layout: view tabs centered, Present (expand/collapse icons) anchored on the right.
OverviewNavigationProviderexposespending; the matrix card dims to 60% opacity after a 150ms delay while a selector fetch is in flight, and clears on success or failure. Unit tests coverpendinglifecycle; Cypress zh locale asserts the short chip label plus fullaria-label.Reviewed by Cursor Bugbot for commit 0385d4b. Bugbot is set up for automated code reviews on this repo. Configure here.