feat(inference): surface DCP and PCP across point views - #745
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cquil11
marked this pull request as ready for review
August 16, 2026 18:55
cquil11
force-pushed
the
agent/surface-dcp-pcp
branch
from
August 16, 2026 19:04
306c9d8 to
bd5a637
Compare
cquil11
force-pushed
the
agent/surface-dcp-pcp
branch
from
August 16, 2026 19:24
bd5a637 to
a051504
Compare
cquil11
force-pushed
the
agent/surface-dcp-pcp
branch
from
August 16, 2026 19:35
a051504 to
43865f5
Compare
cquil11
force-pushed
the
agent/surface-dcp-pcp
branch
from
August 16, 2026 19:44
43865f5 to
a823492
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a823492. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
dcp_size/pcp_sizeand role-specific prefill/decode DCP/PCP fields when benchmark rows become chart points.TP8/DCP8; PCP is appended when greater than one.Context
Fixes the frontend follow-up identified in the InferenceX #2616 review.
Run 31893747354 attempt 2 emits aggregate
dcp_size: 8andpcp_size: 1; its points and agentic detail chip therefore render asTP8/DCP8, while the default PCP1 remains omitted.Validation
bun run typecheckbun run lintbun run fmtbun run test:unit(3,919 tests passed)unofficial-watermark.cy.ts(rendered SVG point label)agentic-point-time-series.cy.ts(11 tests passed, including the activeTP8/DCP8detail chip)Unofficial-run overlays and agentic detail pages now consume the same benchmark normalization and shared parallelism formatter as official chart points.
Note
Low Risk
Display and data-mapping changes across inference UI and read APIs; no auth or persistence logic. Main risk is inconsistent labels if metrics JSONB is missing or malformed, mitigated by tests and cache namespace rollover.
Overview
Extends the shared parallelism label formatter so decode-context (DCP) and prefill-context (PCP) widths appear in chart point labels when values are greater than one (e.g.
TP8/DCP8,TP8/DCP8/PCP4), while default widths of 1 stay omitted to preserve legacy strings.Benchmark row → chart point mapping now keeps role-specific and aggregate
dcp_size/pcp_sizemetrics from JSONB. Tooltips (official, GPU comparison, unofficial overlays) and agentic sibling chips use the same formatter and show aggregate or per-role DCP/PCP in English and Chinese.The benchmark-siblings query/API adds normalized DCP/PCP on sibling rows (coalescing role fields with aggregate metrics) and bumps the cached response namespace to v3 so agentic detail topology chips match scatter labels. Unit and Cypress tests cover labels, tooltips, unofficial scatter overlays, and the active agentic point chip.
Reviewed by Cursor Bugbot for commit a823492. Bugbot is set up for automated code reviews on this repo. Configure here.