Skip to content

[WIP] Refresh MiniMax-M3 NVFP4 B200 8k1k disaggregated Dynamo-vLLM / 刷新 MiniMax-M3 NVFP4 B200 8k1k 分离式 Dynamo-vLLM 配置#2311

Closed
jasonlizhengjian wants to merge 13 commits into
mainfrom
agent/refresh-minimax-m3-b200-disagg
Closed

[WIP] Refresh MiniMax-M3 NVFP4 B200 8k1k disaggregated Dynamo-vLLM / 刷新 MiniMax-M3 NVFP4 B200 8k1k 分离式 Dynamo-vLLM 配置#2311
jasonlizhengjian wants to merge 13 commits into
mainfrom
agent/refresh-minimax-m3-b200-disagg

Conversation

@jasonlizhengjian

@jasonlizhengjian jasonlizhengjian commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Validation

  • python -m pytest utils/matrix_logic/ utils/changelog_gate_tests/ -q: 299 passed.
  • utils/validate_perf_changelog.py --base-ref origin/main --head-ref HEAD: passed; final newline present and matrix generated.
  • The main-based changelog matrix contains exactly six 8k1k throughput jobs and six eval jobs, all with spec-decoding: none and the refreshed image.
  • git diff --check origin/main...HEAD: passed.

中文说明

验证

  • python -m pytest utils/matrix_logic/ utils/changelog_gate_tests/ -q:299 项通过。
  • utils/validate_perf_changelog.py --base-ref origin/main --head-ref HEAD:通过;文件末尾换行及矩阵生成均正常。
  • 基于 main 生成的变更日志矩阵恰好包含六个 8k1k 吞吐量任务和六个评估任务,全部使用 spec-decoding: none 及新镜像。
  • git diff --check origin/main...HEAD:通过。

xinli-sw and others added 10 commits July 19, 2026 13:30
Merge the latest origin/main and retain the MiniMax-M3 changelog entry at the final append-only position.

中文:合并最新的 origin/main,并将 MiniMax-M3 的变更日志条目保留在文件末尾,确保仅追加顺序不变。
Merge origin/main at 89696c5 and retain the MiniMax-M3 changelog entry at the final append-only position.

中文:合并 origin/main 的 89696c5,并将 MiniMax-M3 的变更日志条目保留在文件末尾,确保仅追加顺序不变。
Refresh the six non-speculative MiniMax-M3 NVFP4 B200 8k1k Dynamo-vLLM recipes while preserving their topology and sweep parameters.

中文:刷新六个非投机 MiniMax-M3 NVFP4 B200 8k1k Dynamo-vLLM 配置,并保持现有拓扑与扫描参数不变。
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

Replace the temporary changelog placeholder with the canonical pull-request URL.

中文:将变更日志中的临时占位符替换为规范的 PR 链接。
@jasonlizhengjian jasonlizhengjian added the non-canary-full-sweep-enabled Run the full sweep without the canary gate (full search space, no trim) label Jul 23, 2026 — with ChatGPT Codex Connector
@jasonlizhengjian
jasonlizhengjian marked this pull request as ready for review July 23, 2026 15:45
@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Claude finished @jasonlizhengjian's task in 1m 47s —— View job


Review of PR #2311

  • Gather context (diff vs origin/feat/minimaxm3-b200-vllm-disagg)
  • Verify master config + perf-changelog rules
  • Verify image accessibility and recipe consistency
  • Validation checks (see note below)
  • Post review

LGTM - no blocking issues found

Verified against the stacked base feat/minimaxm3-b200-vllm-disagg:

  • The diff is exactly the image bump — configs/nvidia-master.yaml (minimaxm3-fp4-b200-dynamo-vllm) plus all six non-speculative 8k1k recipe YAMLs move from vllm/vllm-openai:cu129-nightly-8e981630c... to vllm/vllm-openai:nightly-4080263bb...; topology, Dynamo version, and concurrency sweeps are untouched.
  • perf-changelog.yaml was updated alongside the master config, the new entry is appended at the very end of the file, references the correct config key, and the file keeps its final newline.
  • No stale references to the old image remain anywhere in the repo (the only occurrence is in the changelog text, which is expected).
  • The new image is a public Docker Hub reference — no local paths or .sqsh files.

Note: this review sandbox blocks running pytest/network calls, so I could not independently rerun the test suite or confirm the Docker Hub tag exists — CI will exercise both, and the PR description reports 299 tests passing locally.

Keep one canonical changelog entry for the main-based refresh PR so the sweep selects the B200 configuration once.

中文:为基于 main 的刷新 PR 保留一条规范的变更日志记录,确保扫描仅选择一次 B200 配置。
Remove trailing whitespace from the newly added separator before the B200 refresh entry.

中文:移除 B200 刷新记录前新增分隔行中的尾随空格。
@jasonlizhengjian
jasonlizhengjian changed the base branch from feat/minimaxm3-b200-vllm-disagg to main July 23, 2026 15:49
@jasonlizhengjian
jasonlizhengjian requested a review from a team July 23, 2026 15:49
@jasonlizhengjian jasonlizhengjian removed the non-canary-full-sweep-enabled Run the full sweep without the canary gate (full search space, no trim) label Jul 23, 2026
@jasonlizhengjian jasonlizhengjian added the non-canary-full-sweep-enabled Run the full sweep without the canary gate (full search space, no trim) label Jul 23, 2026 — with ChatGPT Codex Connector
@github-actions

Copy link
Copy Markdown
Contributor

@jasonlizhengjian

Copy link
Copy Markdown
Collaborator Author

Closing because MiniMax-M3 NVFP4 B200 disaggregated Dynamo-vLLM is not an existing recipe family on main, so this was an unintended new-family addition rather than a container refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-canary-full-sweep-enabled Run the full sweep without the canary gate (full search space, no trim)

Projects

Development

Successfully merging this pull request may close these issues.

2 participants