Add GLM-5.1 FP8 B300 SGLang configurations / 新增 GLM-5.1 FP8 B300 SGLang 配置#2320
Add GLM-5.1 FP8 B300 SGLang configurations / 新增 GLM-5.1 FP8 B300 SGLang 配置#2320RohitNagraj wants to merge 3 commits into
Conversation
Add the B300 SGLang benchmark entry and script with writable model-cache fallback. 中文:新增 B300 SGLang 基准测试配置和脚本,并在模型未预置时使用可写缓存。
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
Record the pull request URL for the GLM-5.1 FP8 B300 SGLang configuration. 中文:记录 GLM-5.1 FP8 B300 SGLang 配置的拉取请求链接。
中文:新增 GLM-5.1 FP8 B300 SGLang MTP 配置,并将其变更日志关联到 #2320。
| glm5-fp8-b300-sglang: | ||
| image: lmsysorg/sglang:v0.5.15.post1-cu130 | ||
| model: zai-org/GLM-5.1-FP8 | ||
| model-prefix: glm5 | ||
| runner: b300 | ||
| precision: fp8 | ||
| framework: sglang | ||
| multinode: false | ||
| scenarios: | ||
| fixed-seq-len: | ||
| - isl: 8192 | ||
| osl: 1024 | ||
| search-space: | ||
| - { tp: 8, ep: 1, conc-start: 4, conc-end: 256 } |
There was a problem hiding this comment.
🔴 The new config sets model-prefix: glm5 for model zai-org/GLM-5.1-FP8, but every other GLM-5.1 config in the repo uses glm5.1 — GLM-5 and GLM-5.1 are distinct models. Because the deprecated glm5-fp8-b300-sglang config for the unrelated zai-org/GLM-5-FP8 model used the identical prefix glm5 with the same runner/tp/ep/isl/osl/conc, utils/compare_results.py's baseline lookup (a prefix LIKE match) will silently pick historical GLM-5 rows as the regression baseline for this GLM-5.1 config. Should be model-prefix: glm5.1.
Extended reasoning...
The bug: configs/nvidia-master.yaml sets model: zai-org/GLM-5.1-FP8 but model-prefix: glm5 (line ~1291). Every other GLM-5.1-FP8/GLM-5.1-NVFP4 entry in the repo (e.g. configs/deprecated/nvidia-glm5-glm5.1-master.yaml lines 650, 957, 1261, 1382, 1525, 1782) uses model-prefix: glm5.1, while GLM-5 (non-5.1) entries use glm5. This new config breaks that convention, using the GLM-5 prefix for a GLM-5.1 model.
Code path: The model-prefix YAML field flows through generate_sweep_configs.py into the MODEL_PREFIX env var, then into infmax_model_prefix in the result JSON written by benchmark_lib.sh. utils/compare_results.py reads this value (model = result['infmax_model_prefix'].lower()) and uses it in its regression-baseline query:
WHERE ... AND c.model LIKE %(model)s || '%%' ...
ORDER BY br.date DESC LIMIT 1With model = 'glm5', this becomes LIKE 'glm5%', which matches BOTH 'glm5' and 'glm5.1' rows in the DB, since 'glm5' is a literal prefix of 'glm5.1'.
Why this causes contamination, concretely: The deprecated config key glm5-fp8-b300-sglang previously existed in configs/deprecated/nvidia-glm5-glm5.1-master.yaml (lines 40-53) for the distinct model zai-org/GLM-5-FP8, also with model-prefix: glm5, and identical hardware/framework/precision/tp/ep/isl/osl/conc (b300/sglang/fp8/tp8/ep1/isl8192/osl1024/conc 4-256). Every other column in BASELINE_QUERY's WHERE clause matches between the old GLM-5 rows and this new GLM-5.1 config. So:
- The new GLM-5.1 sweep runs and writes a result with
c.model = 'glm5'(frominfmax_model_prefix). compare_results.pyruns its baseline query withmodel = 'glm5', i.e.LIKE 'glm5%'.- If any historical main-branch row exists with
c.model = 'glm5'from the old GLM-5 (not 5.1) config, it satisfies every filter andORDER BY date DESC LIMIT 1picks it as 'the' baseline. - The regression report silently compares GLM-5.1 throughput/latency numbers against an unrelated GLM-5 model's historical numbers, instead of correctly reporting 'no baseline' for this first GLM-5.1 B300 SGLang run.
If model-prefix were correctly set to glm5.1, the query would be LIKE 'glm5.1%', which does not match plain 'glm5' rows (since 'glm5' does not start with 'glm5.1'), correctly isolating GLM-5.1 baselines from GLM-5 ones.
Why nothing else catches this: The WHERE clause intentionally uses a prefix LIKE match (per the comment above BASELINE_QUERY) to handle cases like model-prefix: gptoss matching DB model gptoss120b — a legitimate use of prefix matching for suffix variation. That same permissiveness backfires here because glm5 is also a valid, distinct model family name that is a literal string-prefix of glm5.1. There's no additional disambiguation column (e.g. exact model name) in the baseline query to prevent this collision.
Fix: change model-prefix: glm5 to model-prefix: glm5.1 in this new config entry, consistent with every other GLM-5.1 config in the repository. Separately, this also means results from this config would otherwise be permanently mislabeled under the glm5 model family in the results DB, independent of the baseline-lookup issue.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30052832516 |
|
/reuse-sweep-run |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:
Signed: |
✅✅✅ Verdict: PASS ✅✅✅✅ Check 0 (CODEOWNER): PASS — |
|
Thanks for the contribution! A couple of things to flag: the GLM 5.1 architecture is already deprecated (see PR #2276) in favor of GLM 5.2. All submitters including Nick and Xin at NVIDIA are both in agreement on this deprecation as well awhile ago. Everyone was given 3-4 weeks' written notice ahead of the submission cutoff, so we'd ask that any new work target the 5.2 architecture going forward. |
Summary
lmsysorg/sglang:v0.5.15.post1-cu130.中文说明
lmsysorg/sglang:v0.5.15.post1-cu130镜像。