fix(ci): report persistent staged runs / 修复预发布运行持久化状态提示 - #2412
Conversation
Update staging acknowledgments and completion callbacks to reflect cumulative run retention and same-run updates. 中文：更新预发布请求确认与完成回调，明确多个运行会持续保留，重复发布同一运行会更新其数据。
|
Claude finished @cquil11's task in 1m 31s —— View job LGTM - no blocking issues found The changes are messaging-only updates inside |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — straightforward user-facing message wording update in two workflow files, no logic changes.
What was reviewed: the diff only touches string literals in the PR-comment bodies of stage-results.yml and stage-results-callback.yml; the surrounding authorization, validation, run-selection, and dispatch logic is untouched. Checked that the new Chinese/English copy accurately reflects the described persistent-staging behavior, and that the messaging change doesn't itself depend on the companion app PR being merged (the workflow logic is unchanged, only wording).
Extended reasoning...
Overview
This PR modifies only the templated comment bodies (body/message strings) in two GitHub Actions workflow files: stage-results.yml (the request/acknowledge step) and stage-results-callback.yml (the completion callback step). It adds bilingual (English + Simplified Chinese) copies of the same message and updates the wording to describe persistent multi-run staging instead of a single shared/serialized slot. No control flow, authorization checks, input validation regexes, permissions blocks, or dispatch payloads were changed.
Security risks
None identified. The changed lines are static template literals interpolating already-validated values (requestedBy, runId, URLs built from validated inputs) that were already being interpolated into comment bodies before this change. No new user input is introduced, no new interpolation sources, and no permission or auth logic is touched.
Level of scrutiny
Low. This is a pure copy/messaging change to CI-generated PR comments — cosmetic in nature and fully reversible (a comment can be edited/reworded again with no functional impact on the staging system itself). The actual behavioral change (persistent multi-run staging vs. destructive restore) lives in the separate InferenceX-app PR #643 referenced in the description; this PR only keeps the text in sync.
Other factors
The bug-hunting system found no bugs. One candidate concern was raised and ruled out: that the new copy promises persistence guaranteed only by the unmerged companion PR. I agree this isn't a blocking issue — the description explicitly frames this as a paired rollout, and worst case (companion PR not yet merged) the comment would be briefly aspirational rather than incorrect about anything security- or correctness-relevant in this repo. actionlint and git diff --check were run per the PR description. No CODEOWNERS-restricted paths are touched beyond the two workflow files already in scope for this kind of change.
1 participant
Summary
/stage-resultsacknowledgments to state that existing staged runs are preserved.Companion PR
This messaging change accompanies InferenceX-app PR #643, which removes the default destructive Neon restore and implements persistent multi-run staging. The app PR provides the functional behavior; this PR keeps the InferenceX command contract and user-facing status accurate.
Validation
actionlint .github/workflows/stage-results.yml .github/workflows/stage-results-callback.ymlgit diff --check中文说明
变更概述
/stage-results请求确认提示，明确已有的预发布运行会继续保留。配套 PR
本提示变更与 InferenceX-app PR #643 配套。app PR 会移除默认执行的破坏性 Neon 恢复操作，实现多运行持久化预发布；本 PR 则同步更新 InferenceX 的命令语义和用户提示。实际功能由 app PR 提供。
验证
actionlint .github/workflows/stage-results.yml .github/workflows/stage-results-callback.ymlgit diff --check