Skip to content

[AMD][AgentX] Kimi-K3 MI355X DSpark wrapper (kimik3_fp4_mi355x_mtp.sh) #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyukjlee wants to merge 1 commit into from
Closed

[AMD][AgentX] Kimi-K3 MI355X DSpark wrapper (kimik3_fp4_mi355x_mtp.sh) #2509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions benchmarks/single_node/agentic/kimik3_fp4_mi355x_mtp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#!/usr/bin/env bash

Check warning on line 1 in benchmarks/single_node/agentic/kimik3_fp4_mi355x_mtp.sh

View check run for this annotation

Claude / Claude Code Review

PR title/description missing required Chinese translation 

The PR title and description are English-only, but AGENTS.md requires every PR title/description to be bilingual (title format `<English title> / <中文标题>`, plus a `## 中文说明` section in the body).

@claude claude Bot Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The PR title and description are English-only, but AGENTS.md requires every PR title/description to be bilingual (title format <English title> / <中文标题>, plus a ## 中文说明 section in the body).

Extended reasoning...

AGENTS.md (top of the repo's AI-agent guidance, line 7) states explicitly:

PR and GitHub-issue titles & descriptions must be bilingual — include a Simplified Chinese version in addition to English. Title format: <English title> / <中文标题>. In the PR/issue body, follow the English content with its Chinese translation (e.g. a ## 中文说明 section mirroring the summary; don't translate code blocks, logs, or stack traces — summarize around them) ... This applies to every PR and every issue, matching the bilingual docs rule in Code Conventions.

This PR's title, [AMD][AgentX] Kimi-K3 MI355X DSpark wrapper (kimik3_fp4_mi355x_mtp.sh), has no trailing / <中文标题> segment, and the body (Summary table + "⚠️ Merge order" note) is entirely in English with no ## 中文说明 section or any Chinese text at all.

Step-by-step proof:

  1. Open AGENTS.md and read the block starting > **PR and GitHub-issue titles & descriptions must be bilingual...** — it unambiguously requires a <中文标题> suffix on every PR title and a Chinese-language section in every PR body.
  2. Read this PR's title in the metadata: [AMD][AgentX] Kimi-K3 MI355X DSpark wrapper (kimik3_fp4_mi355x_mtp.sh) — no / followed by Chinese characters anywhere.
  3. Read the PR description: it contains only ## Summary, a markdown table, and ## ⚠️ Merge order, all in English. There is no ## 中文说明 heading and no Chinese-script characters anywhere in the body.
  4. Therefore the PR violates the explicit "applies to every PR and every issue" clause with no exception applicable here (the only stated exception is for the CODEOWNER sign-off template and bot-generated comments, neither of which applies to the PR author's own title/description).

This is a repo-mandated process convention, not a subjective style preference, so it's worth flagging even though it has zero effect on the shell script's runtime correctness (the bash -n-clean wrapper script itself is fine). It does not block the DSpark wrapper logic from working, so it shouldn't hold up merge — the author can simply add a <中文标题> to the title and append a ## 中文说明 section summarizing the change in Chinese.

set -euo pipefail

# DSpark variant of kimik3_fp4_mi355x.sh. The MI355X launcher routes
# spec-decoding=mtp rows to this suffix, while the shared base recipe owns the
# model, AgentX replay, and eval plumbing.
#
# Keep this wrapper aligned with the upstream AMD Kimi-K3 DSpark reproducer.
# The first AgentX validation is deliberately GPU-only at c1 so a server or
# kernel failure has nowhere else to hide.
export SPEC_DECODE=true
export KV_CACHE_DTYPE="${KV_CACHE_DTYPE:-auto}"
export GPU_MEM_UTIL="${GPU_MEM_UTIL:-0.95}"
export MAX_NUM_SEQS="${MAX_NUM_SEQS:-16}"
export EVAL_MAX_NUM_SEQS="${EVAL_MAX_NUM_SEQS:-128}"
export MAX_NUM_BATCHED_TOKENS="${MAX_NUM_BATCHED_TOKENS:-4096}"
export LANGUAGE_MODEL_ONLY="${LANGUAGE_MODEL_ONLY:-false}"
export PREFIX_CACHING="${PREFIX_CACHING:-auto}"
export ENFORCE_EAGER="${ENFORCE_EAGER:-false}"

exec "$(dirname "$0")/kimik3_fp4_mi355x.sh" "$@"