Load landing icon size overrides via Book theme custom.scss#43
Merged
Sendipad merged 3 commits intoFeb 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
staticCSS rules were not guaranteed to be included in the final theme stylesheet.customimport point inthemes/book/assets/book.scss, which is the correct extension spot to ensure style overrides are compiled into the active theme CSS.Description
assets/custom.scssto constrain.feature-icon,.doctype-icon,.usecase-iconand their nestedsvgsizes so landing icons have a fixed maximum visual size.custom).Testing
themes/book/assets/book.scssimportscustomsoassets/custom.scsswill be compiled into the theme CSS (inspection succeeded).assets/custom.scssusingrgand file listing (succeeded).https://sendipad.github.io/uph/using Playwright to validate visual appearance after the change (script ran and saved a screenshot successfully).Codex Task