Open
Conversation
filkovsp
reviewed
Feb 18, 2022
Contributor
filkovsp
left a comment
filkovsp
left a comment
There was a problem hiding this comment.
hi,
this PR still has issues.
changing pixels to rems and ems doesn't really make much of a difference.
the class hierarchy and usage of classes is still not that appropriate. no need to create a class for each DOM element. combine class and tag names in css file (that will make your jsx less overloaded) and may be css file too.
in Advice.js import of Advice.jpg must be fixed, react compiler appears to be case sensitive to the file names and craps out into the console when it starts in local.
try switching your browser into dev mode (F12) and turn on the mobile device mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.