Skip to content

IRS on YOUR doorstep #343

Open
TryHardo7 wants to merge 6 commits into
SerbiaStrong-220:masterfrom
TryHardo7:IRS_is_calling
Open

IRS on YOUR doorstep #343
TryHardo7 wants to merge 6 commits into
SerbiaStrong-220:masterfrom
TryHardo7:IRS_is_calling

Conversation

@TryHardo7

@TryHardo7 TryHardo7 commented Jun 11, 2026

Copy link
Copy Markdown

Промежуточный реворк налоговой системы от оффов
Основан на трекере:
https://discord.com/channels/1097181193939730453/1514028175846408312

Налог начинается от 5 000 000 (0%) и доходит до 12 000 000 (99%)
≤ 5M | 0%
6M | ~14%
7M | ~29%
8M | ~43%
9M | ~57%
10M | ~71%
11M | ~86%
12M+ | 100% (потолок 99%)

Добавлена вот такая кнопочка, позволяющая осуществлять переводы между счетами. Доступно только в лобби.

image

Требования

🆑 Lanc

  • add: В лобби добавлена кнопка "Сбережения". Она позволяет переводить деньги между сберегательным счётом и основным.
  • tweak: Изменён налоговый порог, теперь налоговая будет вмешиваться в депозиты на счета от 5 миллионов и до 12 миллионов с максимальным эффектом.
  • fix: Смерть в нищите отменяется, мы снова богатые и уважаемые аристократы.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a lobby-time savings transfer system between a character's main bank account and account-wide savings (MonoCoins), including a new UI window and managers on both the client and server sides. Additionally, it updates the deposit tax calculation in SharedBankSystem.cs to apply a progressive marginal tax rate. Feedback on these changes highlights a critical integer overflow vulnerability in the server-side transfer request handler when processing int.MinValue, as well as missing style guide markers (// Exodus-begin / // Exodus-end) for modifications made to upstream files.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Content.Server/_Exodus/Bank/SavingsTransferManager.cs
Comment thread Content.Shared/_NF/Bank/SharedBankSystem.cs
Comment thread Content.Client/Lobby/ClientPreferencesManager.cs

@Surani1 Surani1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too fast enough. Good job

Comment thread Content.Shared/_Mono/CCVar/CCVars.Mono.cs Outdated
@TryHardo7 TryHardo7 changed the title [wip] IRS on YOUR doorstep IRS on YOUR doorstep Jun 11, 2026

@Lokilife Lokilife left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Учимся пространствам имён C#

Comment thread Content.Client/Entry/EntryPoint.cs Outdated
Comment thread Content.Client/IoC/ClientContentIoC.cs Outdated
Comment thread Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs Outdated
Comment thread Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs Outdated
Comment thread Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs
Comment thread Content.Server/_Exodus/Bank/SavingsTransferManager.cs Outdated
Comment thread Content.Server/Entry/EntryPoint.cs Outdated
Comment thread Content.Server/IoC/ServerContentIoC.cs Outdated
Comment thread Content.Shared/_Mono/CCVar/CCVars.Mono.cs
Comment thread Content.Shared/_NF/Bank/SharedBankSystem.cs

@Lokilife Lokilife left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg if tested

Comment thread Content.Shared/_NF/Bank/SharedBankSystem.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants