Skip to content

Check for orphaned tickets #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

koratalas
Copy link
Contributor

This instance check helps identifying all the tickets without assignment groups.

@niamccash niamccash self-assigned this Oct 8, 2024
@niamccash
Copy link
Contributor

Thanks for your contribution! The check should work as is and I'll accept/merge your PR now but I would recommend that the check be improved to avoid the GlideRecord query you have in the script. The query is a call to the database and too many of those can slow down your platform so it's always a good practice to be judicious about how/when you use them (ie. not use them if you don't have to).

In this case, you should be able to add to the condition directly in the Check without having to script it as you already have the Incident record available.

Feel free to submit another PR if you want to try and improve this check.

@niamccash niamccash merged commit f9b2063 into ServiceNowDevProgram:master Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants