Skip to content

Created "Do not use hard-coded sys_ids Contri" record on the table "s… #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<reverted_from/>
<source>a33d22c047397110243ff19f016d43fa</source>
<source_table>sys_upgrade_history</source_table>
<state>current</state>
<state>previous</state>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2023-10-05 20:43:22</sys_created_on>
<sys_id>184d62c047397110243ff19f016d43a4</sys_id>
Expand All @@ -102,7 +102,7 @@
<update_guid_history>d44d62c0e739711006b12536250952a4:-1288508107</update_guid_history>
</sys_update_version>
<sys_metadata_delete action="INSERT_OR_UPDATE">
<sys_audit_delete display_value="Don't use new Array()">4976874c47797110243ff19f016d43ef</sys_audit_delete>
<sys_audit_delete display_value="">4976874c47797110243ff19f016d43ef</sys_audit_delete>
<sys_class_name>sys_metadata_delete</sys_class_name>
<sys_created_by>smartcarleen</sys_created_by>
<sys_created_on>2023-10-05 22:33:28</sys_created_on>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,14 @@
<update_guid_history>169615aaf122111071af545cbffcdb5e:1517693554</update_guid_history>
</sys_update_version>
<sys_metadata_delete action="INSERT_OR_UPDATE">
<sys_audit_delete display_value="User Roles from Deleted Users">0ac7ddaa07221110e765f9fc7c1ed09b</sys_audit_delete>
<sys_audit_delete display_value="">0ac7ddaa07221110e765f9fc7c1ed09b</sys_audit_delete>
<sys_class_name>sys_metadata_delete</sys_class_name>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2022-10-17 23:19:31</sys_created_on>
<sys_db_object display_value="" name="scan_table_check">scan_table_check</sys_db_object>
<sys_id>17859954039f4abebc7d0e2289a8edc4</sys_id>
<sys_metadata>0306196a07221110e765f9fc7c1ed07b</sys_metadata>
<sys_mod_count>0</sys_mod_count>
<sys_name>User Roles from Deleted Users</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_parent/>
Expand All @@ -82,5 +83,7 @@
<sys_scope_delete display_value="">30a78b9b9290467a96959a65d2b2d304</sys_scope_delete>
<sys_update_name>scan_table_check_0306196a07221110e765f9fc7c1ed07b</sys_update_name>
<sys_update_version display_value="scan_table_check_0306196a07221110e765f9fc7c1ed07b">da9615aa07221110e765f9fc7c1ed05e</sys_update_version>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2024-10-30 10:37:25</sys_updated_on>
</sys_metadata_delete>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
<reverted_from/>
<source>a33d22c047397110243ff19f016d43fa</source>
<source_table>sys_upgrade_history</source_table>
<state>current</state>
<state>previous</state>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2023-10-05 20:43:24</sys_created_on>
<sys_id>f04da2c047397110243ff19f016d43e2</sys_id>
Expand All @@ -104,7 +104,7 @@
<update_guid_history>b04da2c075397110e824409ae7478ee2:-932205653</update_guid_history>
</sys_update_version>
<sys_metadata_delete action="INSERT_OR_UPDATE">
<sys_audit_delete display_value="Access controls on Tables">0176830047b97110243ff19f016d43e4</sys_audit_delete>
<sys_audit_delete display_value="">0176830047b97110243ff19f016d43e4</sys_audit_delete>
<sys_class_name>sys_metadata_delete</sys_class_name>
<sys_created_by>smartcarleen</sys_created_by>
<sys_created_on>2023-10-05 22:33:28</sys_created_on>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
<reverted_from/>
<source>a33d22c047397110243ff19f016d43fa</source>
<source_table>sys_upgrade_history</source_table>
<state>current</state>
<state>previous</state>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2023-10-05 20:43:24</sys_created_on>
<sys_id>784da2c047397110243ff19f016d43e8</sys_id>
Expand All @@ -104,7 +104,7 @@
<update_guid_history>384da2c05a397110be15161e1fd2b8e8:-1513497005</update_guid_history>
</sys_update_version>
<sys_metadata_delete action="INSERT_OR_UPDATE">
<sys_audit_delete display_value="Access controls on UI Pages">4976830047b97110243ff19f016d43ea</sys_audit_delete>
<sys_audit_delete display_value="">4976830047b97110243ff19f016d43ea</sys_audit_delete>
<sys_class_name>sys_metadata_delete</sys_class_name>
<sys_created_by>smartcarleen</sys_created_by>
<sys_created_on>2023-10-05 22:33:28</sys_created_on>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
<update_guid_history>2f87514b95dd1250d8d7157d4a5955fd:0,e267d9c752dd1250e0ae7bf3aa17e665:-2023533997,eea83dedc1c5de50dcb00ddc90e599ae:1356454248</update_guid_history>
</sys_update_version>
<sys_metadata_delete action="INSERT_OR_UPDATE">
<sys_audit_delete display_value="Script in ACL when Advanced is unchecked">1379110bc3dd1250faa4bd33e4013183</sys_audit_delete>
<sys_audit_delete display_value="">1379110bc3dd1250faa4bd33e4013183</sys_audit_delete>
<sys_class_name>sys_metadata_delete</sys_class_name>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2024-10-21 18:10:05</sys_created_on>
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2GkIkYTRLHBrnaK0BLk-XjxdsvdTIZ9jJdpNRMX35K_6xuWTi5y1Ry99K-DOjlG11wqAiWwvl7aCdE4ZWrSiATbI0lxnUdQ9WxlKwYNvs1x4VCYSXFOyYvTvKT3kiAZAzCrckOa4Em4EIaQWsrb_I8Hs0bgKv33rj-ePUrlm_eyaKJ2rnW23umP3MLy86FEu-J5jxkDLisX7iqlAtjOoRsUQBweQsMoxupOYvfpdE9hb2_IVDL9CoKdTg80_4ggyJ8PNBz0-61EPdmnU7cRKcwrgivmxrwlsMZRJ1uYb2HSI-uveGE4A7AF1o6mBZIz6ssbtFd7EiA0adaGXD5P15jiG014hPjkYP4HKiiA0_Yjt6wL60LGi3OSCJ9gd8YGeijcceUhadJ8o7-_9kKB87bMrCZLimt0eMOU9IP8roKLd8mrCC7yROA1N93b861zaMf9Rya_aFIMJAxF42hodGemepQf6byCLRA_-rQf6UZS9gCn3BUKuaXq3SQ-zJZRa8abRZPslmATdHB_qc3qD-zHdKaau-2U4IjCX5uN8_zJWyiHrskGbzNbjghd7A0IyCLH5cWiIxHZp41YeMQQhXX0ZQyhH8rnFFviKVQkfU9MEVdpqhBTLKe5B0bM5sXYhejFEzKJayrE0FcpgYQhxsN3AyPQpH5w62LMaCkTbugU
XwYWgF_RgCfq9W2rP9dsKHeJbZGdj-h74z2oDOlfDw3vXesh-TXJ61UjuHdsfGhuNObsGSTauO-z80LCe7y1YTBuCWejpy8kwJp5ZmswmLre4FpAN_o9WNNvfBj57DSSQafvCo4aMS4mWh-zwJurT1DErdGAH7cmnGtdjmQU0hTWu8VNSjgERKjKYJlky299gImjru3-0IBGJkhTKBSg1TkXUfVVCJcmh0Mgc2WliF22hjHZgxghJuAYWCDmV7BFXcfHXIlEvJXK4vkuSsClZd0dzWdRHHIQ7jsW5W8G3rY_0H2YJixYkarvQQW3pzNYsiKW5Cob76ZLsQkATWZmLGPzNn5RDQnNJfA6J0Tmo-CCfprWJJmygdLqttXJQzbECsNsWZZxyNafD5ck7r21mZwhKKA2pcx-_9oOUCn3YmECwHKEDb3GNqcJsWiGZKV4KKLBxh7dnXr2MKBL29kDlygZskywwG6Li2kcTYNtZcLVTj_HdLGMUG4KdvUINIvmK44R69CjsvOcBqOuizg98G73-jyFdMJ1hj-h4MsN2Lfb5mEYFDMZ3am4Ow868tdCr8gtUXDHAYlDA5evNOsyjAsyGHoP-C7fHGf83Y9DVeYDztBoyLrgXECePpVn2rP9yZJMtt3NvdsgPccds832CCdP1UZ6xN4hqsGI143ftGk
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<enforce_license>log</enforce_license>
<guided_setup_guid/>
<hide_on_ui>false</hide_on_ui>
<ide_created/>
<installed_as_dependency>false</installed_as_dependency>
<js_level>helsinki_es5</js_level>
<licensable>true</licensable>
Expand All @@ -15,6 +16,7 @@
<logo/>
<menu/>
<name>Example Instance Checks</name>
<package_json/>
<private>false</private>
<restrict_table_access>false</restrict_table_access>
<runtime_access_tracking/>
Expand All @@ -24,6 +26,7 @@
<source>x_appe_exa_checks</source>
<store_correlation_id/>
<store_url/>
<subscription_entitlement/>
<sys_class_name>sys_app</sys_class_name>
<sys_code/>
<sys_created_by>daniel.draes</sys_created_by>
Expand All @@ -40,4 +43,5 @@
<vendor_prefix/>
<version>1.0.0</version>
</sys_app>
<sys_translated_text action="delete_multiple" query="documentkey=ca8467c41b9abc10ce0f62c3b24bcbaa"/>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@
<sys_updated_by>ali.abdulrazak</sys_updated_by>
<sys_updated_on>2021-10-11 17:02:49</sys_updated_on>
</scan_column_type_check>
<sys_translated_text action="delete_multiple" query="documentkey=4514d5c7400730107f44dbb3b15cf295"/>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2023-10-31 17:25:20</sys_updated_on>
</scan_column_type_check>
<sys_translated_text action="delete_multiple" query="documentkey=c5493fd897523110839d76021153afb8"/>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<category>performance</category>
<description>If a cache flush is triggered as part of a non-ootb script execution this will require the platform to rebuild the cache before returning to its BAU state. This activity has a significant performance impact.</description>
<documentation_url>https://developer.servicenow.com/app.do#!/api_doc?v=newyork&amp;id=r_SGSYS-setProperty_S_S_S</documentation_url>
<finding_type/>
<name>Cache flushed as part of scripts</name>
<priority>2</priority>
<resolution_details>Remove any cache flush triggers unless necessary. Recommended is only the pre-defined cache flush actions that are built into out the box solutions.&#13;
Expand Down Expand Up @@ -62,4 +63,5 @@ Care should be taken when setting system properties (sys_properties) using this
<sys_updated_by>mark.roethof</sys_updated_by>
<sys_updated_on>2021-10-03 16:55:38</sys_updated_on>
</scan_linter_check>
<sys_translated_text action="delete_multiple" query="documentkey=0b7623d41b1afc10ce0f62c3b24bcb24"/>
</record_update>
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,5 @@ For the rare cases where you are interested in the whole XML document, simply mu
<sys_updated_by>mark.roethof</sys_updated_by>
<sys_updated_on>2021-10-02 17:26:47</sys_updated_on>
</scan_linter_check>
<sys_translated_text action="delete_multiple" query="documentkey=0eeac3042f0730103307235df699b6d1"/>
</record_update>
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_linter_check">
<scan_linter_check action="INSERT_OR_UPDATE">
<active>true</active>
<attributes/>
<category>security</category>
<description>The eval() function evaluates or executes an argument. Improper use of eval() opens up your code for injection attacks and debugging can be more challenging, as no line numbers are displayed with an error, for example.</description>
<documentation_url>https://developer.servicenow.com/dev.do#!/guides/rome/now-platform/tpb-guide/scripting_technical_best_practices#avoid-the-eval-function-</documentation_url>
Expand Down Expand Up @@ -39,4 +38,5 @@ GlideEvaluator.evaluateString("gs.log('Hello World');");</resolution_details>
<sys_updated_by>nia.mccash</sys_updated_by>
<sys_updated_on>2021-10-02 14:12:05</sys_updated_on>
</scan_linter_check>
<sys_translated_text action="delete_multiple" query="documentkey=1043deaf2ffa7c505dcb59ab2799b6a6"/>
</record_update>
Loading
Loading