Skip to content

Check any approvals waiting in inactive users queue #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,20 @@ Open-Sourced community contributed and owned repository for Instance Scan Defini
# Checks in this repository

## Category: Manageability
### Inactive user check : Catalog task Assigned To

### Inactive user check: Approvals
Check any approvals waiting in inactive users queue

### Inactive user check: Catalog task Assigned To
Check any Catalog Tasks Assigned to Inactive user

### Check any assets assigned to inactive user
Check if any asset is assigned to inactive users.

### Inactive User Check : Catalog Item
### Inactive User Check: Catalog Item
We should ensure that inactive users are removed from being assigned as Catalog item owners.

###Avoid gs.log()Statement
### Avoid gs.log()Statement
Use Logging Levels: Instead of gs.log(), consider using more appropriate logging levels, such as:
gs.info() for informative messages.
gs.warn() for warnings that don’t break functionality but may need attention.
Expand Down Expand Up @@ -276,7 +280,8 @@ Select the check box to ignore flushing some server-side caches, thus flushing o
Avoid using gs.sleep() in any script because it does not release session and will cause delays, and add logs to the script whenever gs.sleep() has to be used.

## Category: Security
##Check Mandatory fields on incident

### Check Mandatory fields on incident
This check is used to find mandatory fields on incident

### Avoid using setBasicAuth for REST messages
Expand Down Expand Up @@ -345,7 +350,7 @@ Scripts in ACLs ARE executed regardless of whether or not the Advanced checked b
### Added a Number Prefix which already exists
Creating new number records does not require uniqueness. Though having duplicate number records causes some ServiceNow core functionality not to behave as expected. For example, the search might return a record from another table the number prefix is also used on.

## List Inactive users from active group
### List Inactive users from active group
List inactive users that still belongs to activate groups

### HTTP connection records not excluded on clones from Prod
Expand Down
2 changes: 1 addition & 1 deletion ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ad39iLllwcXyHcClv7tIwd87V8cvRPeDsEWhujC7w1DXOJARowOvatgfrJ6huznwKD8Ym_GIVfl7PZ1NAb0TvBct1I5MCraGOXtinvkZTnKtuTjEnnJsqRyGMyFb_-Viy2859sV9UchleBGNZcdOAoYS9VxgJipc3kAkVY-8drBXYR-fgsuqdjibiGMamqIBK-T0jH31vi5l08hbDYl6CjUnsec_PicEvjqH4VRO1PI0yxa0opSkycRNQaOeWDCTCnCmXmAO_h7tPnTY4ukpLX6P7pNr7S5VHsRErCHo3xWx1dgQysQRT4d8oGWNLXFS6Ux9VsED9ZGa9muvG3EwfDEBWf1mndDg2aFsJCI0VgvHUWxtXAYKswTpzpIeonD_UlNy6lry5UTrGn914G5HQj1bkGKssxB_TnZxBhVU70gs7H4YWcZZiymK4ZVypdxO97eU-PMaFIeEeg-KI2RNHOllDrmVgI9SMgmUrAzm7UHQnvwD9ZZjESMKLav2aZikMuPuZcvuLA5FJOWR4U2clQuD-57-8EIsp-nUvLK6km2axLfgWaUNfhuz-0nCpuCny-egrIAYwImdUvEd0hmOmN8F0Y1s3buIBJBFIzxeXwEleYzHofdgxpI3LB2GYfkLjakhitC1oa6nCtPJ3QvyOYJQG6WwiSPl6iZvCMxS45Y
PvIJkj0CrrOfy28QU4MMOVPIVwbWwbZNEk791oAm_r9fD0zBfYoaliv_t3ocWE-jyR_-Dkn3tSDp9qH83fL1xeyAC9JcPXdfC7xPPrY1OIdhX-5GZfO5IV8vWlIkvLri0B_Z06LS33VbB6r4RYl-bZ6_qqCGwanl8ZpEONw91C1yFp3TyBjrXuvPSLaH-xPboIx_im9iKOVKphzJIzR3HqKBRTQXh1DbVHygA0qHTUPaoHgeoMASJ3DsL9OBfaBYmcNN7vc2LQaHbAwZQjRLm7bttFhM-JLEJZr8JRXFfnCIdqQdJGE5z5LHYfkpiWAIpUIBr76PiKus3cvc3vYI78aSRaC1DkwKdIYq6LpQfrkeULVsZGQt_-zhqwA6trToVpr6-KZbWFFUUM-WnMGii9QRKBjMFpMOrKC6JPwrHNUWvBDdeX0iD3Yazn2-j1kt8klH5muw0MnNqT4gtWd62asS6cabYF4Nernw4RZJedWzYDRmZURbnQNLx93BFbQqMF0ky0jMxYy3Ff3yJDo2SzuutMtE8VLa0BVadhasdYUtzgl_q0S4M_DSkozXdOoxSUTIapSZKrudXX7rhu-7i0-knQaJccfmhSBc7aQ4I-yVLhT5PDTY_BO6chD5iM2XxNYzXaKGTrGRDzyGjofq5YYIE8xdxwFzj-W2W95RaF8
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
<scan_table_check action="INSERT_OR_UPDATE">
<active>true</active>
<advanced>false</advanced>
<category>manageability</category>
<conditions table="sysapproval_approver">approver.active=false^EQ<item endquery="false" field="approver.active" goto="false" newquery="false" operator="=" or="false" value="false"/>
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
</conditions>
<description>Check any approvals waitin on inactive users queue</description>
<documentation_url/>
<finding_type>scan_finding</finding_type>
<name>Inactive user check : Approval</name>
<priority>1</priority>
<resolution_details/>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
<score_scale>1</score_scale>
<script><![CDATA[(function (engine) {

// Add your code here

})(engine);]]></script>
<short_description>Check any approvals waitin on inactive users queue</short_description>
<sys_class_name>scan_table_check</sys_class_name>
<sys_created_by>admin</sys_created_by>
<sys_created_on>2024-10-31 15:26:29</sys_created_on>
<sys_id>8de1905683e512103d6c98c6feaad3b9</sys_id>
<sys_mod_count>0</sys_mod_count>
<sys_name>Inactive user check : Approval</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_update_name>scan_table_check_8de1905683e512103d6c98c6feaad3b9</sys_update_name>
<sys_updated_by>admin</sys_updated_by>
<sys_updated_on>2024-10-31 15:26:29</sys_updated_on>
<table>sysapproval_approver</table>
<use_manifest>false</use_manifest>
</scan_table_check>
<sys_translated_text action="delete_multiple" query="documentkey=8de1905683e512103d6c98c6feaad3b9"/>
</record_update>
Loading