feat(#358): add database connection pool monitoring metrics#384
Open
Escelit wants to merge 1 commit into
Open
Conversation
|
@Escelit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Escelit pls resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #358
This PR introduces database connection pool monitoring to the
MetricsService. Previously, the application lacked visibility into the TypeORM connection pool, making it impossible to detect pool exhaustion under high load.Changes Made
DataSourceintoMetricsService.Gaugemetrics to track the database pool state in real-time:db_pool_active_connections: The number of clients currently checked out and actively executing queries.db_pool_idle_connections: The number of clients currently idle and available in the pool.db_pool_waiting_queries: The number of queued queries waiting for a database connection to become available.These metrics utilize
prom-client'scollectcallback functions to dynamically evaluate the state of the Postgrespg.Poolunderlying the TypeORM connection, providing efficient and real-time observability.Type of Change
Testing
collectmethods appropriately handle cases where the pool may not be fully initialized or exposed.