fix(#684): @Async에 실행기 이름 명시 — applicationTaskExecutor 대신 무제한 폴백을 조용히 쓰던 문제 수정 - #685
Merged
Merged
Conversation
… 쓰던 문제 수정 Executor 타입 빈이 둘(applicationTaskExecutor · Boot 자동구성 taskScheduler)이라 이름 없는 @async가 어느 쪽도 못 고르고 SimpleAsyncTaskExecutor(호출마다 새 스레드, 무제한)로 조용히 폴백하고 있었다 — H1 재측정 중 발견(executor_completed_tasks_total이 0에서 안 움직이는데 스레드 이름은 호출마다 계속 올라감). @async("applicationTaskExecutor") 로 명시해 애매성을 없앴다. 재빌드 후 실제 호출로 즉시 검증(0.0 → 1.0), 기존 테스트 14건(ExerciseAnalysisServiceTest·PoseDataCleanupServiceTest·ApplicationTaskExecutorMetricsTest) 전부 통과. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016jrgkFgxLjQtjJbDHX7Ue9
Member
Author
|
@coderabbitai review |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applicationTaskExecutor· Boot 자동구성taskScheduler)이라 이름 없는@Async가 어느 쪽도 못 고르고SimpleAsyncTaskExecutor(호출마다 새 스레드, 무제한)로 조용히 폴백하고 있었다 —@Async 풀 백프레셔H1 재측정 중 발견.sendAnalysisRequestToFastApi(ExerciseAnalysisService)·PoseDataCleanupService의@Async에@Async("applicationTaskExecutor")로 이름을 명시해 애매성을 없앤다.Test plan
executor_completed_tasks_total0.0 → 1.0)ExerciseAnalysisServiceTest·PoseDataCleanupServiceTest·ApplicationTaskExecutorMetricsTest통과Closes #684
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01RTbqudA4PvdfQAic48NNPo
🤖 Generated with Claude Code
https://claude.ai/code/session_01RTbqudA4PvdfQAic48NNPo